From 42c9ed80755f3b2b31507f00568d6a79ca42928e Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Fri, 19 Aug 2016 23:00:40 +0000 Subject: [PATCH] sysctl-handle-error-writing-uint_max-to-u32-fields-checkpatch-fixes WARNING: please, no spaces at the start of a line #101: FILE: kernel/sysctl.c:2297: + return do_proc_dointvec(table,write,buffer,lenp,ppos,$ ERROR: space required after that ',' (ctx:VxV) #101: FILE: kernel/sysctl.c:2297: + return do_proc_dointvec(table,write,buffer,lenp,ppos, ^ ERROR: space required after that ',' (ctx:VxV) #101: FILE: kernel/sysctl.c:2297: + return do_proc_dointvec(table,write,buffer,lenp,ppos, ^ ERROR: space required after that ',' (ctx:VxV) #101: FILE: kernel/sysctl.c:2297: + return do_proc_dointvec(table,write,buffer,lenp,ppos, ^ ERROR: space required after that ',' (ctx:VxV) #101: FILE: kernel/sysctl.c:2297: + return do_proc_dointvec(table,write,buffer,lenp,ppos, ^ WARNING: ENOSYS means 'invalid syscall nr' and nothing else #115: FILE: kernel/sysctl.c:2899: + return -ENOSYS; total: 4 errors, 2 warnings, 74 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. ./patches/sysctl-handle-error-writing-uint_max-to-u32-fields.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Subash Abhinov Kasiviswanathan Signed-off-by: Andrew Morton --- kernel/sysctl.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 96437af5849995..d82f8a52ba8cdd 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -2274,8 +2274,7 @@ static int do_proc_dointvec(struct ctl_table *table, int write, int proc_dointvec(struct ctl_table *table, int write, void __user *buffer, size_t *lenp, loff_t *ppos) { - return do_proc_dointvec(table,write,buffer,lenp,ppos, - NULL,NULL); + return do_proc_dointvec(table, write, buffer, lenp, ppos, NULL, NULL); } /** @@ -2294,7 +2293,7 @@ int proc_dointvec(struct ctl_table *table, int write, int proc_douintvec(struct ctl_table *table, int write, void __user *buffer, size_t *lenp, loff_t *ppos) { - return do_proc_dointvec(table,write,buffer,lenp,ppos, + return do_proc_dointvec(table, write, buffer, lenp, ppos, do_proc_douintvec_conv, NULL); }