Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code organisation for better first coder experience #3

Closed
bourgeoa opened this issue Nov 20, 2021 · 2 comments · Fixed by #17
Closed

Code organisation for better first coder experience #3

bourgeoa opened this issue Nov 20, 2021 · 2 comments · Fixed by #17
Labels
documentation Improvements or additions to documentation

Comments

@bourgeoa
Copy link
Contributor

A good idea could be to make an auth.js separating login/logout from the rest of the app

@NoelDeMartin
Copy link
Member

Hm I don't know if that would be better, I like that we only have two JS files. And it's only two to separate Solid specifics from app code, it was a single file in the first version but we decided to separate them to make Hello Worlds in other protocols using the same template. Maybe we could reorder the contents of solid.js instead or separate auth from CRUD with comments? Or maybe more files is better?

Any thoughts @rosano?

@rosano
Copy link
Member

rosano commented Nov 20, 2021

This is the kind of optimization that should be considered after the other protocols are implemented (be it in other repositories, or in this one). The separation of Solid concerns from the rest of the app is instructive for first-timers. Let's see what emerges and decide later.

@NoelDeMartin NoelDeMartin added the documentation Improvements or additions to documentation label Dec 2, 2021
@rosano rosano linked a pull request Dec 18, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants