-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace render path in write nodes from stagingDir #58
base: develop
Are you sure you want to change the base?
Replace render path in write nodes from stagingDir #58
Conversation
stagingDir could use dynamic path, using {version} or some unique descriptor. Render path of write nodes used this path only during creation, this updates each publish run.
|
This is only replacing/updating values in path as `...vXXXX...` to `...vXXXX+1...`
Question: Does limiting path rewrites for I dont fully understand |
Move logic to extractor phase after workfile version is bumped up. |
Now write_node is directly provided, no need to do weird checks. Added get_version_from_path as version from ayon-core doesn't apply for version as subdirectory.
…fix/AY-7342_Nuke-write-nodes-path-doesnt-recalculate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way it works perfectly!
Co-authored-by: Roy Nieterau <[email protected]>
…path-doesnt-recalculate' into bugfix/AY-7342_Nuke-write-nodes-path-doesnt-recalculate
Baking script needs to be checked. |
Changelog Description
Custom
stagingDir
(ayon+settings://core/tools/publish/custom_staging_dir_profiles
) could use dynamic portion, using {version} or some unique descriptor. Render path of write nodes sets thisstagingDir
path only during creation time (eg. it stays static), this updates each publish run.New publish plugin was created in
Other
section which updates version in render path to matching work workfile version (which got just bumped up step before). That wayrenders
subfolders would be unique.This plugin is optional and by default its disabled.
Additional review information
Use case for this would be to sending multiple jobs do Deadline with suspended Publish job. Artist then will visually check all rendered images and enable only appropriate
Publish
job.Issue is how to build unique portion of path,
{version}
doesn't work as it points to published version of product. Time component (like{ddmmyyyy}
) doesn't seem to work.Another issue is if path in write nodes should be refreshed all the time, or it should be configurable in Settings (and by default disabled). (Problem there is that one needs to remember prepare custom staging dir template AND enable it in
CollectNukeWrites
)Testing notes:
ayon+settings://nuke/publish/IncrementWriteNodePath
resolves #55