Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in the hash implementation? #6

Open
VioletGiraffe opened this issue Jul 10, 2019 · 3 comments
Open

Bug in the hash implementation? #6

VioletGiraffe opened this issue Jul 10, 2019 · 3 comments

Comments

@VioletGiraffe
Copy link

This doesn't look right - I mean the 0: https://github.com/whitfin/siphash-c/blob/master/src/siphash.c#L62

@hartwork
Copy link

I second that it looks wrong. If it turns out right, I could use an in-code comment.

@whitfin
Copy link
Owner

whitfin commented Jul 10, 2019

I don't have time to jump into this right now, but afaict it's correct. If you can give me a case where the output is incorrect, I can work on it.

@VioletGiraffe
Copy link
Author

I have used this function to hash text strings, and I had A LOT of colliding strings of length 3. Just 3! I then used this implementation and it works fine: https://github.com/veorq/SipHash

Try these two strings: 3Ct and 3CD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants