Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking issue] patches from IA's morituri fork to rebase to whipper #35

Open
MerlijnWajer opened this issue Sep 19, 2016 · 4 comments
Assignees
Labels
Story Issue used to track progress on multiple related issues in a single place
Milestone

Comments

@MerlijnWajer
Copy link
Collaborator

MerlijnWajer commented Sep 19, 2016

This is a tracking issue (for me) to contribute back the following changes that I made to our/my private fork of morituri. Context: I use morituri as-a-library (kind of), so we never invoke the main ripping code. This led me to having to shuffle a lot of code around, so in the end I'll also want to see if we can make whipper available as a library in a nice way. That involves removing various calls to exit(), for example.

Some of these features you may not want to merge even if rebased, because they may conflict with morituri's original goals (rip perfect, always twice, etc).

I will add expected dates (for PRs) soon, and update the issue accordingly.

@MerlijnWajer
Copy link
Collaborator Author

Somewhat far off, but possible after most of this is contributed, is(for someone) to make a Qt frontend.

@JoeLametta
Copy link
Collaborator

shardz had a tool for peak detection, IIRC

Merged (#48).
GStreamer peak detection is still there.

@RecursiveForest
Copy link
Contributor

RecursiveForest commented Oct 21, 2016

Correct, I didn't bother removing the gstreamer peak code so that merging a non-rebased -gst patch would have fewer conflicts. However, all actually-used peak calculations use sox now.

@JoeLametta
Copy link
Collaborator

Updated task list:

@JoeLametta JoeLametta added Story Issue used to track progress on multiple related issues in a single place and removed enhancement labels Nov 11, 2018
@JoeLametta JoeLametta modified the milestones: 2.0, backlog Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Story Issue used to track progress on multiple related issues in a single place
Projects
None yet
Development

No branches or pull requests

3 participants