From f9d758aa2662dbb83f81cbcaad296b8053ca5c9f Mon Sep 17 00:00:00 2001 From: timifasubaa <30888507+timifasubaa@users.noreply.github.com> Date: Fri, 23 Mar 2018 15:31:47 -0700 Subject: [PATCH] add yarn lock info to contributing.md (#4679) --- CONTRIBUTING.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b337dad4d8c78..7f7ff50ae6c26 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -259,6 +259,10 @@ superset runserver -d -p 8081 npm run dev ``` +#### Upgrading npm packages + +Should you add or upgrade a npm package, which involves changing `package.json`, you'll need to re-run `yarn install` and push the newly generated `yarn.lock` file so we get the reproducible build. More information at (https://yarnpkg.com/blog/2016/11/24/lockfiles-for-all/) + ## Testing Before running python unit tests, please setup local testing environment: