Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let's (try to) remove the # level in the route https://rnbw.dev/#/... #857

Open
edenvidal opened this issue Jun 2, 2024 · 7 comments
Open

Comments

@edenvidal
Copy link
Member

edenvidal commented Jun 2, 2024

during my recent attempt, i could change it but then lost the ability to redirect back to the main root for when somone is trying to re-open a folder they recently edited using a link.

@edenvidal edenvidal converted this from a draft issue Jun 2, 2024
@edenvidal edenvidal removed this from rnbw 0.1 Jun 2, 2024
@edenvidal edenvidal moved this to Idea in rnbw 1.0 Jun 2, 2024
@edenvidal edenvidal removed this from rnbw 1.0 Jun 2, 2024
@edenvidal edenvidal moved this to Idea in rnbw 0.1 Jun 2, 2024
@edenvidal edenvidal moved this from Idea to Next Up in rnbw 0.1 Jun 16, 2024
@edenvidal edenvidal changed the title let's remove the # level in the route https://rnbw.dev/#/... let's (try to_ remove the # level in the route https://rnbw.dev/#/... Jun 30, 2024
@edenvidal edenvidal changed the title let's (try to_ remove the # level in the route https://rnbw.dev/#/... let's (try to) remove the # level in the route https://rnbw.dev/#/... Jun 30, 2024
@atulbhatt-system32
Copy link
Contributor

@edenvidal Just sharing why hash is required. As far as I remember routing was implemented by @vicki29 and I also had the same question to her why hash is there. But seems like it was required to implemented for the routing purpose.

So @stanislavasal when you work on it keep a thorough check on routing functionality.

@edenvidal edenvidal moved this from Next Up to Idea in rnbw 0.1 Dec 19, 2024
@edenvidal edenvidal moved this from Idea to Next Up in rnbw 0.1 Dec 22, 2024
@edenvidal edenvidal assigned edenvidal and unassigned edenvidal Dec 22, 2024
@kareem-g
Copy link
Contributor

@edenvidal Is the saving functionality a known issue or still unimplemented? I’m unable to test the links e.g.,(http://www.example.com/#/folder/123) inside the app because the project saving isn’t working. Could you explain how this should function?

Image

@edenvidal
Copy link
Member Author

@kareem-g, this is a welcome project that lives in your local storage. if you want it on your desktop, you'll need to download and reopen it. alternatively, you can open an existing codebase, and once you make a change, it will sync and save either automatically (using jumpstart/autosave-on/off) or by pressing command+s. i’m not sure how this relates to the issue though.

@kareem-g
Copy link
Contributor

@kareem-g, this is a welcome project that lives in your local storage. if you want it on your desktop, you'll need to download and reopen it. alternatively, you can open an existing codebase, and once you make a change, it will sync and save either automatically (using jumpstart/autosave-on/off) or by pressing command+s. i’m not sure how this relates to the issue though.

Ok I understand now how saving works, but can you explain what's needed to be fixed? you mean makes it open the recent project by default (so when refreshing or open by a link it doesn't open the default welcome project)? I tested out this and it returns me to a welcome project when I try to open a recent project by link like: http://localhost:8080/#/saved-project/index.html and my suggested solution is open the most recent project project saved by default so when refreshing or opening by a link it don't return me to the default welcome project.

am I wrong about something? if yes please clarify. if not tell me so I work on it.

@edenvidal
Copy link
Member Author

@kareem-g the task is to remove the # from the route while ensuring routing functionality still works properly.

@edenvidal
Copy link
Member Author

@atulbhatt-system32, i know @kareem-g tried it but i am not sure

@kareem-g
Copy link
Contributor

@atulbhatt-system32, i know @kareem-g tried it but i am not sure

I am looking into a fix and trying to understand why the # is used in the first place. I will provide you with a clear answer tomorrow if I manage to fix it or have already done so. If not, I will let you know as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Idea
Development

No branches or pull requests

4 participants