Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valid but unverified JWT querystring values should override all other tokens #334

Open
squince opened this issue Aug 31, 2016 · 0 comments

Comments

@squince
Copy link
Contributor

squince commented Aug 31, 2016

https://github.com/wballard/starphleet/blob/master/overlay/var/starphleet/nginx/lua/jwt.lua#L145-L173

Currently the code looks to see if there is a verified jwt token in the querystring and if so, uses it - taking priority over any potential cookie jwt and authorization header jwt.

But we need to distinguish between a valid token and a verified token. If someone passes a jwt querystring that has expired, it is unverified, but still valid and should force the user to see the login page regardless of whether they also passed a valid and verified jwt cookie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant