From 80bbe653d14c80341a8a8e0041c82f057c0c2a53 Mon Sep 17 00:00:00 2001 From: "chantal.kelm" Date: Wed, 8 Jun 2022 12:15:12 -0300 Subject: [PATCH 1/6] solution --- public/kibana-integrations/kibana-vis.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/public/kibana-integrations/kibana-vis.js b/public/kibana-integrations/kibana-vis.js index 7bc49a1230..a25ab7ccc1 100644 --- a/public/kibana-integrations/kibana-vis.js +++ b/public/kibana-integrations/kibana-vis.js @@ -109,7 +109,9 @@ class KibanaVis extends Component { componentWillUnmount() { if (this._isMounted) { this._isMounted = false; - this.updateVis(); + if (this.deadField) { + return this.renderComplete(); + } this.destroyAll(); } } From 6327d45676e325284d2e1d490c16622efce2cd09 Mon Sep 17 00:00:00 2001 From: "chantal.kelm" Date: Wed, 8 Jun 2022 12:21:42 -0300 Subject: [PATCH 2/6] comment --- public/kibana-integrations/kibana-vis.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/public/kibana-integrations/kibana-vis.js b/public/kibana-integrations/kibana-vis.js index a25ab7ccc1..c4264ac59a 100644 --- a/public/kibana-integrations/kibana-vis.js +++ b/public/kibana-integrations/kibana-vis.js @@ -109,6 +109,9 @@ class KibanaVis extends Component { componentWillUnmount() { if (this._isMounted) { this._isMounted = false; + // It would be good to continue investigating if it is necessary for the renderComplete() to be in the componentWillUnmount. + // In the renderComplete() the value of the $rootScope is changed, which affects the entire application. + // Issue worked on: https://github.com/wazuh/wazuh-kibana-app/issues/4158 if (this.deadField) { return this.renderComplete(); } From 9b82e7172d519af446a81605783880f8c195aead Mon Sep 17 00:00:00 2001 From: "chantal.kelm" Date: Wed, 8 Jun 2022 13:01:52 -0300 Subject: [PATCH 3/6] changelog --- CHANGELOG.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4fc71d4d94..67437572fb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,16 @@ All notable changes to the Wazuh app project will be documented in this file. +## Wazuh v4.3.5 - Kibana 7.10.2, 7.16.x, 7.17.x - Revision 4306 + +### Added + +### Changed + +### Fixed + +-TypeError: main view of Agents [#4233](https://github.com/wazuh/wazuh-kibana-app/pull/4233) + ## Wazuh v4.3.4 - Kibana 7.10.2, 7.16.x, 7.17.x - Revision 4305 ### Added From 4a1142e73a375401a282880f78cf731b7a5804df Mon Sep 17 00:00:00 2001 From: "chantal.kelm" Date: Thu, 9 Jun 2022 07:11:30 -0300 Subject: [PATCH 4/6] changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 67437572fb..929984bc00 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,7 +10,7 @@ All notable changes to the Wazuh app project will be documented in this file. ### Fixed --TypeError: main view of Agents [#4233](https://github.com/wazuh/wazuh-kibana-app/pull/4233) +- Fixed error in console when changing screen size in agents section [#4233](https://github.com/wazuh/wazuh-kibana-app/pull/4233) ## Wazuh v4.3.4 - Kibana 7.10.2, 7.16.x, 7.17.x - Revision 4305 From 0b2ba0233b429efd71b6c3f4bb5f06db1bd0da25 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=81lex?= Date: Mon, 13 Jun 2022 16:25:26 +0200 Subject: [PATCH 5/6] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d9e274d26e..f699416347 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,7 @@ All notable changes to the Wazuh app project will be documented in this file. ### Fixed -- Fixed error in console when changing screen size in agents section [#4233](https://github.com/wazuh/wazuh-kibana-app/pull/4233) +- Fixed type error when changing screen size in agents section [#4233](https://github.com/wazuh/wazuh-kibana-app/pull/4233) ### Changed From 6c7b54d263658874bd4faefa21711f474ff6390a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=81lex?= Date: Mon, 13 Jun 2022 16:27:14 +0200 Subject: [PATCH 6/6] Update kibana-vis.js --- public/kibana-integrations/kibana-vis.js | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/public/kibana-integrations/kibana-vis.js b/public/kibana-integrations/kibana-vis.js index c4264ac59a..27e2adc156 100644 --- a/public/kibana-integrations/kibana-vis.js +++ b/public/kibana-integrations/kibana-vis.js @@ -109,9 +109,14 @@ class KibanaVis extends Component { componentWillUnmount() { if (this._isMounted) { this._isMounted = false; - // It would be good to continue investigating if it is necessary for the renderComplete() to be in the componentWillUnmount. - // In the renderComplete() the value of the $rootScope is changed, which affects the entire application. - // Issue worked on: https://github.com/wazuh/wazuh-kibana-app/issues/4158 + // It would be good to continue investigating if it is + // necessary for the renderComplete() to be in the + // componentWillUnmount. + // In the renderComplete() the value of the $rootScope + // is changed, which affects the entire application. + // + // Related issue: + // https://github.com/wazuh/wazuh-kibana-app/issues/4158 if (this.deadField) { return this.renderComplete(); }