-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ScreenDetails defines "currentScreens" getter steps #81
Comments
We had a discussion about this in #49 about whether |
You're right, what I'm looking for here is something less strict than In addition to documenting this behavior in the algorithms a note or example explaining the intent would be helpful to make this aspect of the design clear to implementers. |
I attempted to define this a bit better and add a couple notes in #87, but I'm not exactly sure how to use internal slots to define an array and specify which exact {{ScreenDetailed}} object in {{ScreenDetails/screens}} represents the [=/current screen=] of a {{Window}}. I hope this might be sufficient for now, and that we can refine this further at a later date. |
Your PR is a good starting point. You can probably hand-wave the necessary behavior by adding a note in the algorithm that if a |
The
currentScreens
getter steps are currently defined as "return the ScreenDetailed object associated with the Window associated with this." This should be "currentScreen" to match the WebIDL and should be explicit that it returns the "current screen" of theWindow
object associated with this.This raises the related question of whether the
ScreenDetailed
object returned by this attribute should be the same as one of the objects in the sequence returned by thescreens
attribute and whether these objects should be===
comparable. This is something we do for APIs likenavigator.serial.getPorts()
andnavigator.serial.onconnect
so that it is easy to compare the objects involved to see whether the state has changed without having to rely on heuristics like comparing the screen geometry or labels. As implemented in Chromium it appears that this is the case for this API.The text was updated successfully, but these errors were encountered: