-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Origin instead of Referer in the request header #379
Comments
After some discussion internally, we'd like to better understand the rationale of the change. i.e. why The FedCM spec explicitly states that the referrer is set to the "origin" (aka with no path), so the potential risk of "referrer could expose path with certain policy (e.g. @bvandersloot-mozilla could you please shed some light here? |
I don't recall there being a reason that |
@annevk was there any other reason we missed? Unfortunately we forgot the reason mentioned in the discussion. |
So, IIUC, we're talking here about non-CORS requests having the Origin header instead of a Referrer. At least in the past, I've seen servers that use the Origin header to distinguish CORS from non-CORS headers (e.g. to decide if they need to send ACAO, maybe for other things). Are we sure that sending Origin headers on non-CORS requests won't cause weird side-effects? |
Chrome pioneered using the @bvandersloot-mozilla lists the reason, which is also the reason we have With |
OK, thanks! |
Ping here. I think it would be important to clarify this in the spec. |
As agreed in issue 230, we should send Origin instead of Referer:
The text was updated successfully, but these errors were encountered: