Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement binding for round() #246

Merged
merged 9 commits into from
Feb 27, 2023
Merged

Implement binding for round() #246

merged 9 commits into from
Feb 27, 2023

Conversation

thisisnic
Copy link
Contributor

Fixes #191

@thisisnic
Copy link
Contributor Author

thisisnic commented Jan 31, 2023 •
edited
Loading

This can't be progressed until substrait-io/substrait#322 is merged and then we update Substrait here. (done)

@thisisnic
Copy link
Contributor Author

This will need rebasing after #247 is merged

@thisisnic thisisnic changed the title Implement binding for round() for DuckDB Implement binding for round() Feb 23, 2023
@thisisnic thisisnic marked this pull request as ready for review February 23, 2023 08:26
@thisisnic
Copy link
Contributor Author

thisisnic commented Feb 23, 2023 •
edited
Loading

I'm getting segfaults when running this on Acero; have opened apache/arrow#34310

@thisisnic
Copy link
Contributor Author

CI failure unrelated to changes and will be fixed in #251

paleolimbot
paleolimbot approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny formatting thing but other than that good to go! Thank you!

@thisisnic thisisnic merged commit 2999659 into voltrondata:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paleolimbot paleolimbot paleolimbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement bindings to Substrait rounding functions
2 participants
@thisisnic @paleolimbot