Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the tests to work with the latest jupyter server #70

Closed
jtpio opened this issue Dec 16, 2020 · 1 comment · Fixed by #74
Closed

Update the tests to work with the latest jupyter server #70

jtpio opened this issue Dec 16, 2020 · 1 comment · Fixed by #74

Comments

@jtpio
Copy link
Member

jtpio commented Dec 16, 2020

This was noticed when iterating on #69

We should fix the tests so they pass with the latest releases of Jupyter Server. And remove this pin added in #69:

voila-gridstack/setup.py

Line 116 in 27a8402

'jupyter_server~=1.0.1',

Some of the changes include the rename of the fixtures, that now include the jp prefix.

An example run where the tests fail: https://github.com/voila-dashboards/voila-gridstack/runs/1557959257

With:

E       fixture 'base_url' not found

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add base_url fixture for the tests jtpio/voila-gridstack
1 participant
@jtpio