Can't enter space in xeditable in AngularJS 1.7.3 #739
Comments
sherlock1982
referenced
this issue
in angular/angular.js
Sep 6, 2018
By default, pressing spacebar causes the browser to scroll down. However, when a native button is focused, the button is clicked instead. `ngAria`'s `ngClick` directive, sets elements up to behave like buttons. For example, it adds `role="button"` and forwards `ENTER` and `SPACEBAR` keypresses to the `click` handler (to emulate the behavior of native buttons). Yet, pressing spacebar on such an element, still invokes the default browser behavior of scrolling down. This commit fixes this, by calling `preventDefault()` on the keyboard event, thus preventing the default scrolling behavior and making custom buttons behave closer to native ones. Closes #14665 Closes #16604
|
Workaround: downgrade angular-aria to 1.7.2 |
|
The regression should have been fixed with angular/angular.js#16680. It is not released yet (will happen in the next few days - possibly tomorrow). In the meantime, you can try out the latest version from https://code.angularjs.org/snapshot/ and see if the error goes away 🙏 |
|
Should this be closed now that the issue has been merged? |
|
For future reference, the fix is included in v1.7.4. @sherlock1982, can you confirm that upgrading to v1.7.4 fixes the issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Switching from AngularJS 1.7.2 to 1.7.3 breaks ability to enter spaces in input fields.
I have a feeling this is due to this change angular/angular.js@3a517c2
The text was updated successfully, but these errors were encountered: