Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example which demonstrates difference in behavior of return type Result for contracts #956

Open
3 tasks
cmichi opened this issue Oct 13, 2021 · 0 comments
Assignees
Labels
A-examples [examples] Work item

Comments

@cmichi
Copy link
Collaborator

cmichi commented Oct 13, 2021

This is a follow-up to #665.

We should create an example to illustrate how revert-on-Err works. The example should especially highlight that Result behaves different if returned from a root contract vs. returned from child contracts.

ToDo

  • For this purpose the example should have root and a child contract: The child contract should expose a message that returns a Result. The root contract should have a message returning Result as well.
  • The comments should highlight that in the case of root returning Err a revert will happen, whereas for the child contract's Result return no revert will happen.
  • As a follow-up: create an issue in ink-waterfall to test this new example.
@cmichi cmichi added E-blocked The task is blocked on some other task to be finished. A-examples [examples] Work item labels Oct 13, 2021
@cmichi cmichi self-assigned this Oct 31, 2021
@cmichi cmichi removed the E-blocked The task is blocked on some other task to be finished. label Nov 11, 2021
@SkymanOne SkymanOne assigned SkymanOne and unassigned cmichi Apr 12, 2023
@github-project-automation github-project-automation bot moved this to Backlog 🗒 in Smart Contracts Apr 12, 2023
@athei athei removed this from Smart Contracts Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-examples [examples] Work item
Projects
None yet
Development

No branches or pull requests

2 participants