From 90bedd1828154de16e3f33321c7cef5207b862a8 Mon Sep 17 00:00:00 2001 From: Antoine D Date: Thu, 28 Nov 2024 12:54:26 +0100 Subject: [PATCH 1/3] test: trombi --- src/operations/user.ts | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/operations/user.ts b/src/operations/user.ts index 677dac84..1956a163 100644 --- a/src/operations/user.ts +++ b/src/operations/user.ts @@ -258,7 +258,15 @@ export const fetchOrgas = async (): Promise => { }, }, }); - return orgas.map(formatOrga); + return orgas.map((orga) => { + // log the orga to see what it looks like + logger.debug(`Format de l'orga : ${orga.username}`); + logger.debug(orga); + logger.debug(orga.id); + logger.debug(orga.orga.displayName); + const formattedOrga = formatOrga(orga); + return formattedOrga; + }); }; export const createUser = async (user: { From 0d598fbcc3edc1c52ea171a7394c49275dc5397f Mon Sep 17 00:00:00 2001 From: Antoine D Date: Thu, 28 Nov 2024 13:26:24 +0100 Subject: [PATCH 2/3] test: undefined? --- src/operations/user.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/operations/user.ts b/src/operations/user.ts index 1956a163..62e96cc1 100644 --- a/src/operations/user.ts +++ b/src/operations/user.ts @@ -263,7 +263,7 @@ export const fetchOrgas = async (): Promise => { logger.debug(`Format de l'orga : ${orga.username}`); logger.debug(orga); logger.debug(orga.id); - logger.debug(orga.orga.displayName); + logger.debug(orga.orga); const formattedOrga = formatOrga(orga); return formattedOrga; }); From ecf36544107761e27662e48fc5b2a7783520f8d2 Mon Sep 17 00:00:00 2001 From: Antoine D Date: Thu, 28 Nov 2024 13:49:50 +0100 Subject: [PATCH 3/3] fix: trombi don't crash when error in format orga --- src/operations/user.ts | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/operations/user.ts b/src/operations/user.ts index 62e96cc1..b319cfb9 100644 --- a/src/operations/user.ts +++ b/src/operations/user.ts @@ -258,15 +258,16 @@ export const fetchOrgas = async (): Promise => { }, }, }); - return orgas.map((orga) => { - // log the orga to see what it looks like - logger.debug(`Format de l'orga : ${orga.username}`); - logger.debug(orga); - logger.debug(orga.id); - logger.debug(orga.orga); - const formattedOrga = formatOrga(orga); - return formattedOrga; - }); + return orgas + .map((orga) => { + try { + return formatOrga(orga); + } catch (error) { + logger.error(`Error while formatting orga ${orga.id}`, error); + return null; + } + }) + .filter((orga) => orga !== null); }; export const createUser = async (user: {