Skip to content
This repository was archived by the owner on Aug 17, 2020. It is now read-only.

Commit ea28818

Browse files
Merge branch 'master' into config-file
2 parents bbd5aa6 + cd8fc09 commit ea28818

File tree

3 files changed

+35
-1
lines changed

3 files changed

+35
-1
lines changed

agent/agent.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ type (
6060
)
6161

6262
var (
63-
version = "0.1.14-pre1"
63+
version = "0.1.15-pre1"
6464

6565
testingModeFrequency = time.Second
6666
nonTestingModeFrequency = time.Minute

instrumentation/testing/logger.go

+15
Original file line numberDiff line numberDiff line change
@@ -53,13 +53,15 @@ func UnpatchTestingLogger() {
5353

5454
func patchError() {
5555
patch("Error", func(test *Test, argsValues []reflect.Value) {
56+
test.t.Helper()
5657
args := getArgs(argsValues[0])
5758
test.Error(args...)
5859
})
5960
}
6061

6162
func patchErrorf() {
6263
patch("Errorf", func(test *Test, argsValues []reflect.Value) {
64+
test.t.Helper()
6365
format := argsValues[0].String()
6466
args := getArgs(argsValues[1])
6567
test.Errorf(format, args...)
@@ -68,13 +70,15 @@ func patchErrorf() {
6870

6971
func patchFatal() {
7072
patch("Fatal", func(test *Test, argsValues []reflect.Value) {
73+
test.t.Helper()
7174
args := getArgs(argsValues[0])
7275
test.Fatal(args...)
7376
})
7477
}
7578

7679
func patchFatalf() {
7780
patch("Fatalf", func(test *Test, argsValues []reflect.Value) {
81+
test.t.Helper()
7882
format := argsValues[0].String()
7983
args := getArgs(argsValues[1])
8084
test.Fatalf(format, args...)
@@ -83,13 +87,15 @@ func patchFatalf() {
8387

8488
func patchLog() {
8589
patch("Log", func(test *Test, argsValues []reflect.Value) {
90+
test.t.Helper()
8691
args := getArgs(argsValues[0])
8792
test.Log(args...)
8893
})
8994
}
9095

9196
func patchLogf() {
9297
patch("Logf", func(test *Test, argsValues []reflect.Value) {
98+
test.t.Helper()
9399
format := argsValues[0].String()
94100
args := getArgs(argsValues[1])
95101
test.Logf(format, args...)
@@ -98,13 +104,15 @@ func patchLogf() {
98104

99105
func patchSkip() {
100106
patch("Skip", func(test *Test, argsValues []reflect.Value) {
107+
test.t.Helper()
101108
args := getArgs(argsValues[0])
102109
test.Skip(args...)
103110
})
104111
}
105112

106113
func patchSkipf() {
107114
patch("Skipf", func(test *Test, argsValues []reflect.Value) {
115+
test.t.Helper()
108116
format := argsValues[0].String()
109117
args := getArgs(argsValues[1])
110118
test.Skipf(format, args...)
@@ -141,6 +149,13 @@ func patch(methodName string, methodBody func(test *Test, argsValues []reflect.V
141149
instrumentation.Logger().Println("testing.T is nil")
142150
return nil
143151
}
152+
153+
t.Helper()
154+
reflection.AddToHelpersMap(t, []string{
155+
"reflect.callReflect",
156+
"reflect.makeFuncStub",
157+
})
158+
144159
test := GetTest(t)
145160
if test == nil {
146161
instrumentation.Logger().Printf("test struct for %v doesn't exist\n", t.Name())

reflection/reflect.go

+19
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,25 @@ func GetTestMutex(t *testing.T) *sync.RWMutex {
3535
return nil
3636
}
3737

38+
func AddToHelpersMap(t *testing.T, frameFnNames []string) {
39+
t.Helper()
40+
mu := GetTestMutex(t)
41+
if mu != nil {
42+
mu.Lock()
43+
defer mu.Unlock()
44+
}
45+
46+
pointer, err := GetFieldPointerOf(t, "helpers")
47+
if err != nil {
48+
return
49+
}
50+
51+
helpers := *(*map[string]struct{})(pointer)
52+
for _, fnName := range frameFnNames {
53+
helpers[fnName] = struct{}{}
54+
}
55+
}
56+
3857
func GetIsParallel(t *testing.T) bool {
3958
mu := GetTestMutex(t)
4059
if mu != nil {

0 commit comments

Comments
 (0)