From 332c69c7588e37dff24c55dc5950c365d29e35f3 Mon Sep 17 00:00:00 2001 From: Maxime Beauchemin Date: Wed, 11 Apr 2018 15:15:36 -0700 Subject: [PATCH] [bugfix] dedup groupby columns in Deck visualizations (#4801) When specifying the same column twice as a `Extra Data for JS` and `Categorical Color`, an error is issued. This addresses this issue. --- superset/viz.py | 1 + 1 file changed, 1 insertion(+) diff --git a/superset/viz.py b/superset/viz.py index f27406b758a7a..dee7e560d9c07 100644 --- a/superset/viz.py +++ b/superset/viz.py @@ -2036,6 +2036,7 @@ def query_obj(self): if fd.get('js_columns'): gb += fd.get('js_columns') metrics = self.get_metrics() + gb = list(set(gb)) if metrics: d['groupby'] = gb d['metrics'] = self.get_metrics()