Expose WC Included Wallet IDs in ThirdwebManager

Also add tooltips

Author: 0xFirekeeper

Assets/Thirdweb/Editor/ThirdwebManagerEditor.cs

@@ -14,6 +14,7 @@ public class ThirdwebManagerEditor : UnityEditor.Editor
         private SerializedProperty showDebugLogsProp;
         private SerializedProperty optOutUsageAnalyticsProp;
         private SerializedProperty supportedChainsProp;
+        private SerializedProperty includedWalletIdsProp;
         private SerializedProperty redirectPageHtmlOverrideProp;
         private SerializedProperty rpcOverridesProp;
 
@@ -33,6 +34,7 @@ private void OnEnable()
             showDebugLogsProp = FindProperty("ShowDebugLogs");
             optOutUsageAnalyticsProp = FindProperty("OptOutUsageAnalytics");
             supportedChainsProp = FindProperty("SupportedChains");
+            includedWalletIdsProp = FindProperty("IncludedWalletIds");
             redirectPageHtmlOverrideProp = FindProperty("RedirectPageHtmlOverride");
             rpcOverridesProp = FindProperty("RpcOverrides");
 
@@ -139,8 +141,8 @@ private void DrawSelectedTabContent()
         private void DrawClientTab()
         {
             EditorGUILayout.HelpBox("Configure your client settings here.", MessageType.Info);
-            DrawProperty(clientIdProp, "Client ID");
-            DrawProperty(bundleIdProp, "Bundle ID");
+            DrawProperty(clientIdProp, "Client ID", "Your Thirdweb Client ID. You can find this in the Thirdweb Dashboard by creating a project.");
+            DrawProperty(bundleIdProp, "Bundle ID", "You may allowlist a bundle ID in the Thirdweb Dashboard to allow native apps to access our services, eg com.mycompany.myapp");
             DrawButton(
                 "Create API Key",
                 () =>
@@ -153,28 +155,41 @@ private void DrawClientTab()
         private void DrawPreferencesTab()
         {
             EditorGUILayout.HelpBox("Set your preferences and initialization options here.", MessageType.Info);
-            DrawProperty(initializeOnAwakeProp, "Initialize On Awake");
-            DrawProperty(showDebugLogsProp, "Show Debug Logs");
-            DrawProperty(optOutUsageAnalyticsProp, "Opt-Out of Usage Analytics");
+            DrawProperty(initializeOnAwakeProp, "Initialize On Awake", "If enabled, Thirdweb will initialize on Awake. If disabled, you must call ThirdwebManager.Instance.Initialize() manually.");
+            DrawProperty(showDebugLogsProp, "Show Debug Logs", "If enabled, Thirdweb will log debug messages to the console.");
+            DrawProperty(optOutUsageAnalyticsProp, "Opt-Out of Usage Analytics", "If enabled, you may see inconsistent stats in your Thirdweb Dashboard.");
         }
 
         private void DrawMiscTab()
         {
             EditorGUILayout.HelpBox("Configure other settings here.", MessageType.Info);
 
-            // Wallet Connect Settings
-            DrawProperty(supportedChainsProp, "WalletConnect Supported Chains");
+            // RPC Overrides
+            DrawProperty(rpcOverridesProp, "RPC Overrides", "We recommend using our default RPC, but if you encounter issues you may override them by chain id here.");
 
             GUILayout.Space(10);
 
             // Desktop OAuth Settings
-            EditorGUILayout.LabelField("OAuth Redirect Page HTML Override", EditorStyles.boldLabel);
+            EditorGUILayout.LabelField(
+                new GUIContent("OAuth Redirect Page HTML Override", "The HTML displayed after Social Login on Desktop, you may override it to match your branding."),
+                EditorStyles.boldLabel
+            );
             redirectPageHtmlOverrideProp.stringValue = EditorGUILayout.TextArea(redirectPageHtmlOverrideProp.stringValue, GUILayout.MinHeight(75));
 
             GUILayout.Space(10);
 
-            // RPC Overrides
-            DrawProperty(rpcOverridesProp, "RPC Overrides");
+            // Wallet Connect Settings
+            DrawProperty(
+                supportedChainsProp,
+                "WalletConnect Supported Chains",
+                "You technically connect to multiple chains at once with WC, so try to include all chain ids your app wants to support."
+            );
+
+            DrawProperty(
+                includedWalletIdsProp,
+                "WalletConnect Included Wallet IDs",
+                "If displaying less than 3 wallets look for ConnectView script in your hierarchy and edit WC Modal wallet count and other settings there."
+            );
         }
 
         private void DrawDebugTab()
@@ -213,11 +228,11 @@ private void DrawDebugTab()
             );
         }
 
-        private void DrawProperty(SerializedProperty property, string label)
+        private void DrawProperty(SerializedProperty property, string label, string tooltip = null)
         {
             if (property != null)
             {
-                EditorGUILayout.PropertyField(property, new GUIContent(label));
+                EditorGUILayout.PropertyField(property, new GUIContent(label, tooltip));
             }
             else
             {

Assets/Thirdweb/Runtime/Unity/Prefabs/ThirdwebManager.prefab

@@ -52,7 +52,9 @@ MonoBehaviour:
   <ShowDebugLogs>k__BackingField: 1
   <OptOutUsageAnalytics>k__BackingField: 0
   <SupportedChains>k__BackingField: ee6e060000000000
+  <IncludedWalletIds>k__BackingField: []
   <RedirectPageHtmlOverride>k__BackingField: 
+  <RpcOverrides>k__BackingField: []
 --- !u!1001 &5352000285921552497
 PrefabInstance:
   m_ObjectHideFlags: 0

Assets/Thirdweb/Runtime/Unity/ThirdwebManager.cs

@@ -157,6 +157,9 @@ public class ThirdwebManager : MonoBehaviour
         [field: SerializeField]
         private ulong[] SupportedChains { get; set; } = new ulong[] { 421614 };
 
+        [field: SerializeField]
+        private string[] IncludedWalletIds { get; set; } = null;
+
         [field: SerializeField]
         private string RedirectPageHtmlOverride { get; set; } = null;
 
@@ -332,7 +335,8 @@ public async Task<IThirdwebWallet> ConnectWallet(WalletOptions walletOptions)
                     break;
                 case WalletProvider.WalletConnectWallet:
                     var supportedChains = SupportedChains.Select(chain => new BigInteger(chain)).ToArray();
-                    wallet = await WalletConnectWallet.Create(client: Client, initialChainId: walletOptions.ChainId, supportedChains: supportedChains);
+                    var includedWalletIds = IncludedWalletIds == null || IncludedWalletIds.Length == 0 ? null : IncludedWalletIds;
+                    wallet = await WalletConnectWallet.Create(client: Client, initialChainId: walletOptions.ChainId, supportedChains: supportedChains, includedWalletIds: includedWalletIds);
                     break;
                 case WalletProvider.MetaMaskWallet:
                     wallet = await MetaMaskWallet.Create(client: Client, activeChainId: walletOptions.ChainId);

Assets/Thirdweb/Runtime/Unity/Wallets/Core/WalletConnectWallet.cs

@@ -35,7 +35,7 @@ protected WalletConnectWallet(ThirdwebClient client)
             _client = client;
         }
 
-        public async static Task<WalletConnectWallet> Create(ThirdwebClient client, BigInteger initialChainId, BigInteger[] supportedChains)
+        public async static Task<WalletConnectWallet> Create(ThirdwebClient client, BigInteger initialChainId, BigInteger[] supportedChains, string[] includedWalletIds)
         {
             var eip155ChainsSupported = new string[] { };
             if (supportedChains != null)
@@ -44,6 +44,7 @@ public async static Task<WalletConnectWallet> Create(ThirdwebClient client, BigI
             _exception = null;
             _isConnected = false;
             _supportedChains = eip155ChainsSupported;
+            _includedWalletIds = includedWalletIds;
 
             if (WalletConnect.Instance != null && WalletConnect.Instance.IsConnected)
             {