Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with new link popup in WYSIWYG Editor #922

Closed
manuelmoreale opened this issue Apr 22, 2016 · 3 comments
Closed

Problem with new link popup in WYSIWYG Editor #922

manuelmoreale opened this issue Apr 22, 2016 · 3 comments
Labels

Comments

@manuelmoreale
Copy link
Contributor

Issue description:

There's a problem with the new modal introduced in WP 4.5.
Actually there are 2 bugs.

One is related to the z-index and is an easy fix. The modal has a z-index value of 100100 while the main div containing the content of the customizer has a z-index value of 500000

The second bug is a bit more tricky. The popup is displayed using absolute positioning relative to the selected word in the editor and has 4 different alignments. Top and bottom are not a problem since there's always some space on top or on the bottom of the editor. Left aligned is also not a problem since on the right there's the entire screen to work with. The problem is the right aligned. Here's a screen that shows the issue:
screenshot 2016-04-22 14 06 16
As you can see the modal goes out the screen on the left side. The modal is quite wide (almost 400px) so using a wider sidebar is not a solution.
Haven't had time to look into the new link modal to see if there's a way to fix this one.

@aristath
Copy link
Contributor

I hate the WYSIWYG editor...

@aristath
Copy link
Contributor

Can you please try the develop branch now?
editor fields were completely refactored trying to resolve #140 and I think this one was also resolved with it 👍

@aristath aristath added the bug label Apr 27, 2016
@aristath
Copy link
Contributor

Closing this one. :)
According to the comment on #914 (comment) it has been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants