Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform apply always has an update #16

Closed
ocervell opened this issue Sep 18, 2019 · 2 comments
Closed

Terraform apply always has an update #16

ocervell opened this issue Sep 18, 2019 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@ocervell
Copy link

ocervell commented Sep 18, 2019

When re-running the Terraform module multiple times, there is always something to update.

Here is the update in-place that Terraform wants to re-do everytime:

# module.slo.module.slo-cloud-function.module.pubsub_topic.google_pubsub_topic.topic will be updated in-place
  ~ resource "google_pubsub_topic" "topic" {
        id      = "projects/rnm-shared-slo-6c95/topics/slo-svc-pubsub-pubsub-ack"
        labels  = {}
        name    = "slo-svc-pubsub-pubsub-ack"
        project = "rnm-shared-slo-6c95"


      - message_storage_policy {
          - allowed_persistence_regions = [
              - "asia-east1",
              - "asia-east2",
              - "asia-northeast1",
              - "asia-northeast2",
              - "asia-south1",
              - "asia-southeast1",
              - "australia-southeast1",
              - "europe-north1",
              - "europe-west1",
              - "europe-west2",
              - "europe-west3",
              - "europe-west4",
              - "europe-west5",
              - "europe-west6",
              - "northamerica-northeast1",
              - "southamerica-east1",
              - "us-central1",
              - "us-central2",
              - "us-east1",
              - "us-east4",
              - "us-west1",
              - "us-west2",
            ] -> null
        }
    }

Maybe we can set a default for the allowed_persistence_regions list so that Terraform doesn't trigger an update everytime ?

@morgante
Copy link
Contributor

Reported upstream: hashicorp/terraform-provider-google#4766

@paulpalamarchuk
Copy link
Contributor

Issue fixed in 2.18 version, in both "google-beta" and "google" providers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants