Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip3 install needs --user on OS X #289

Closed
ideasculptor opened this issue Oct 17, 2019 · 4 comments
Closed

pip3 install needs --user on OS X #289

ideasculptor opened this issue Oct 17, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request P2 high priority issues triaged Scoped and ready for work

Comments

@ideasculptor
Copy link

Native python on OS X will not allow installs to the global python. All installs must happen with a --user flag. It would be really nice to enable that in the code. At the moment, mac users have to manually run the pip3 install command or modify preconditions.sh n order to get the module to run.

I'll send a PR shortly.

@ideasculptor
Copy link
Author

Adding a variable which gets used as additional params to pip3 in preconditions.sh is easy enough. I have that branch ready to submit as PR.

But I suspect most users would actually prefer a boolean flag that just does the right thing when installing on Mac - detecting if the OS is mac, and then setting --user if it is, rather than just forcing the extra param(s) into all pip3 install calls when the extra param is set in the variable, regardless of platform.

If that's preferred, I can implement that, especially if there is code someone can point me to which does OS detection inside terraform.

@aaron-lane
Copy link
Contributor

Fixed by #290

@aaron-lane aaron-lane added the P2 high priority issues label Dec 2, 2019
@morgante
Copy link
Contributor

morgante commented Dec 2, 2019

An alternative approach, as discussed in #290, would be to split the dependency install into a separate local-exec which can be (optionally) disabled and pre-installed.

@aaron-lane aaron-lane added the triaged Scoped and ready for work label Dec 9, 2019
@bharathkkb
Copy link
Member

fixed by #478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 high priority issues triaged Scoped and ready for work
Projects
None yet
Development

No branches or pull requests

4 participants