diff --git a/superset/assets/src/explore/controls.jsx b/superset/assets/src/explore/controls.jsx index 922b45c8357c6..9f5079c40c7f5 100644 --- a/superset/assets/src/explore/controls.jsx +++ b/superset/assets/src/explore/controls.jsx @@ -206,6 +206,7 @@ export const controls = { percent_metrics: { ...metrics, multi: true, + default: [], label: t('Percentage Metrics'), default: [], validators: [], @@ -1449,6 +1450,16 @@ export const controls = { description: t('Whether to display the legend (toggles)'), }, + show_labels: { + type: 'CheckboxControl', + label: t('Show Labels'), + renderTrigger: true, + default: true, + description: t( + 'Whether to display the labels. Note that the label only displays when the the 5% ' + + 'threshold.'), + }, + show_values: { type: 'CheckboxControl', label: t('Show Values'), diff --git a/superset/assets/src/explore/visTypes.js b/superset/assets/src/explore/visTypes.js index e3b34e94d321d..28f555e0283cb 100644 --- a/superset/assets/src/explore/visTypes.js +++ b/superset/assets/src/explore/visTypes.js @@ -142,7 +142,7 @@ export const visTypes = { ['metric'], ['adhoc_filters'], ['groupby'], - ['limit'], + ['row_limit'], ], }, { @@ -151,11 +151,16 @@ export const visTypes = { controlSetRows: [ ['pie_label_type'], ['donut', 'show_legend'], - ['labels_outside'], + ['show_labels', 'labels_outside'], ['color_scheme'], ], }, ], + controlOverrides: { + row_limit: { + default: 25, + }, + }, }, line: { diff --git a/superset/assets/src/visualizations/nvd3_vis.js b/superset/assets/src/visualizations/nvd3_vis.js index 4619d4ddbf234..e8f7e92937076 100644 --- a/superset/assets/src/visualizations/nvd3_vis.js +++ b/superset/assets/src/visualizations/nvd3_vis.js @@ -272,6 +272,7 @@ export default function nvd3Vis(slice, payload) { if (fd.donut) { chart.donut(true); } + chart.showLabels(fd.show_labels); chart.labelsOutside(fd.labels_outside); chart.labelThreshold(0.05); // Configure the minimum slice size for labels to show up if (fd.pie_label_type !== 'key_percent' && fd.pie_label_type !== 'key_value') {