Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On demand menu not working on iOS #260

Closed
vAlmaraz opened this issue Jun 19, 2015 · 6 comments
Closed

On demand menu not working on iOS #260

vAlmaraz opened this issue Jun 19, 2015 · 6 comments

Comments

@vAlmaraz
Copy link

I am developing a website with this library and I have to build context menu on demand with left trigger.
Some customers complaint about it doesn't work on iOS.
I checked demo website, it doesn't work:
http://medialize.github.io/jQuery-contextMenu/demo/dynamic-create.html
Also I have done a simple modification of demo code to trigger from left click and it doesn't work.

I have seen this bug:
#83
Could it be related to the same issue, and maybe it has not been fixed in on demand feature?

Thank you

@vAlmaraz
Copy link
Author

vAlmaraz commented Jun 19, 2015

I have solved it adding:
$('.context-menu').on('click', function() {});
on line 1327, after:
$document.on({});
in the file: jquery.contextMenu.js

In my case, all context menu triggers have "context-menu" class.

@bbrala
Copy link
Member

bbrala commented Sep 11, 2015

Yeah, its the issue that iOS needs an onclick handler.

onclick="void('iOS needs this');"

You can see that on the left click demo.

@bbrala bbrala closed this as completed Sep 11, 2015
@sanjaykumar2338
Copy link

sanjaykumar2338 commented Apr 4, 2018

@vAlmaraz
i am getting the same issue with context-menu library on iPad.

please let me know where you have add this line of code.

@vAlmaraz
Copy link
Author

vAlmaraz commented Apr 4, 2018

Hi @sanjaykumar2338

I am sorry but it seems the library has changed a bit since I made the change. And I am not working on the project any more.

I think I added it when initializing listeners. Maybe looking at the latest version when I posted the message you can find the line I talked about.

PD: I have edited my message to clarify the changes I made.

@bbrala
Copy link
Member

bbrala commented Apr 5, 2018

@vAlmaraz could you open a new issue for this so i can track it there?

@sanjaykumar2338
Copy link

sanjaykumar2338 commented Apr 9, 2018

@bbrala
I have created a new issue #628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants