Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add median and count_distinct aggregation functions #278

Merged
merged 5 commits into from
Sep 5, 2022
Merged

feat: add median and count_distinct aggregation functions #278

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
96e7698
feat(aggregates): adding median, approx_median and count_distinct fun…
vibhatha Aug 4, 2022
72c0c68
fix(rounding): adding rounding options
vibhatha Aug 4, 2022
5757b98
fix(typo): added period and removed decomposition
vibhatha Aug 15, 2022
568f5fd
fix(review): added precision option and refactored description
vibhatha Sep 5, 2022
7db8984
fix(description): address reviews and update the description
vibhatha Sep 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
144 changes: 144 additions & 0 deletions extensions/functions_arithmetic.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1133,6 +1133,150 @@ aggregate_functions:
- value: fp64
nullability: DECLARED_OUTPUT
return: fp64?
- name: "median"
description: >
Calculate the median for a set of values.

Returns null if applied to zero records. For the integer implementations,
the rounding option determines how the median should be rounded if it ends
up midway between two values. For the floating point implementations,
they specify the usual floating point rounding mode.
impls:
- args:
- name: precision
description: >
Based on required operator performance and configured optimizations
on saving memory bandwidth, the precision of the end result can be
the highest possible accuracy or an approximation.

- EXACT: provides the exact result, rounded if needed according
to the rounding option.
- APPROXIMATE: provides only an estimate; the result must lie
between the minimum and maximum values in the input
(inclusive), but otherwise the accuracy is left up to the
consumer.
options: [ EXACT, APPROXIMATE ]
required: true
- name: rounding
options: [ TIE_TO_EVEN, TIE_AWAY_FROM_ZERO, TRUNCATE, CEILING, FLOOR ]
required: false
- value: i8
nullability: DECLARED_OUTPUT
return: i8?
- args:
- name: precision
description: >
Based on required operator performance and configured optimizations
on saving memory bandwidth, the precision of the end result can be
the highest possible accuracy or an approximation.

- EXACT: provides the exact result, rounded if needed according
to the rounding option.
- APPROXIMATE: provides only an estimate; the result must lie
between the minimum and maximum values in the input
(inclusive), but otherwise the accuracy is left up to the
consumer.
options: [ EXACT, APPROXIMATE ]
required: true
- name: rounding
options: [ TIE_TO_EVEN, TIE_AWAY_FROM_ZERO, TRUNCATE, CEILING, FLOOR ]
required: false
- value: i16
nullability: DECLARED_OUTPUT
return: i16?
- args:
- name: precision
description: >
Based on required operator performance and configured optimizations
on saving memory bandwidth, the precision of the end result can be
the highest possible accuracy or an approximation.

- EXACT: provides the exact result, rounded if needed according
to the rounding option.
- APPROXIMATE: provides only an estimate; the result must lie
between the minimum and maximum values in the input
(inclusive), but otherwise the accuracy is left up to the
consumer.
options: [ EXACT, APPROXIMATE ]
required: true
- name: rounding
options: [ TIE_TO_EVEN, TIE_AWAY_FROM_ZERO, TRUNCATE, CEILING, FLOOR ]
required: false
- value: i32
nullability: DECLARED_OUTPUT
return: i32?
- args:
- name: precision
description: >
Based on required operator performance and configured optimizations
on saving memory bandwidth, the precision of the end result can be
the highest possible accuracy or an approximation.

- EXACT: provides the exact result, rounded if needed according
to the rounding option.
- APPROXIMATE: provides only an estimate; the result must lie
between the minimum and maximum values in the input
(inclusive), but otherwise the accuracy is left up to the
consumer.
options: [ EXACT, APPROXIMATE ]
required: true
- name: rounding
options: [ TIE_TO_EVEN, TIE_AWAY_FROM_ZERO, TRUNCATE, CEILING, FLOOR ]
required: false
- value: i64
nullability: DECLARED_OUTPUT
return: i64?
- args:
- name: precision
description: >
Based on required operator performance and configured optimizations
on saving memory bandwidth, the precision of the end result can be
the highest possible accuracy or an approximation.

- EXACT: provides the exact result, rounded if needed according
to the rounding option.
- APPROXIMATE: provides only an estimate; the result must lie
between the minimum and maximum values in the input
(inclusive), but otherwise the accuracy is left up to the
consumer.
options: [ EXACT, APPROXIMATE ]
required: true
- name: rounding
options: [ TIE_TO_EVEN, TIE_AWAY_FROM_ZERO, TRUNCATE, CEILING, FLOOR ]
required: false
- value: fp32
nullability: DECLARED_OUTPUT
return: fp32?
- args:
- name: precision
description: >
Based on required operator performance and configured optimizations
on saving memory bandwidth, the precision of the end result can be
the highest possible accuracy or an approximation.

- EXACT: provides the exact result, rounded if needed according
to the rounding option.
- APPROXIMATE: provides only an estimate; the result must lie
between the minimum and maximum values in the input
(inclusive), but otherwise the accuracy is left up to the
consumer.
options: [ EXACT, APPROXIMATE ]
required: true
- name: rounding
options: [ TIE_TO_EVEN, TIE_AWAY_FROM_ZERO, TRUNCATE, CEILING, FLOOR ]
required: false
- value: fp64
nullability: DECLARED_OUTPUT
return: fp64?
- name: "count_distinct"
description: Count of unique values in a set of values.
impls:
- args:
- options: [SILENT, SATURATE, ERROR]
required: false
- value: any
nullability: DECLARED_OUTPUT
return: i64
window_functions:
- name: "row_number"
description: "the number of the current row within its partition."
Expand Down