From ffed4eb250e53b4a8c48dfddb1f5cace6c665c58 Mon Sep 17 00:00:00 2001 From: Neal Richardson Date: Wed, 3 Aug 2022 09:35:43 -0400 Subject: [PATCH 1/2] feat: add and_not boolean function --- extensions/functions_boolean.yaml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/extensions/functions_boolean.yaml b/extensions/functions_boolean.yaml index cd0629a09..2d1aa4ccd 100644 --- a/extensions/functions_boolean.yaml +++ b/extensions/functions_boolean.yaml @@ -19,6 +19,15 @@ scalar_functions: variadic: min: 2 return: boolean + - + name: and_not + description: The boolean and of one value and the negation of the other using Kleene logic. + impls: + - args: + - value: boolean + variadic: + min: 2 + return: boolean - name: xor description: The boolean xor of two values using Kleene logic. From 5166193f58774c181e79d34ec7c5bc732480baea Mon Sep 17 00:00:00 2001 From: Phillip Cloud <417981+cpcloud@users.noreply.github.com> Date: Wed, 10 Aug 2022 15:37:02 -0400 Subject: [PATCH 2/2] style: fix trailing space --- proto/substrait/algebra.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proto/substrait/algebra.proto b/proto/substrait/algebra.proto index 3d52b1c5b..36b878c5c 100644 --- a/proto/substrait/algebra.proto +++ b/proto/substrait/algebra.proto @@ -368,7 +368,7 @@ message Rel { message NamedObjectWrite { // The list of string is used to represent namespacing (e.g., mydb.mytable). // This assumes shared catalog between systems exchanging a message. - // + // repeated string names = 1; substrait.extensions.AdvancedExtension advanced_extension = 10; }