From e4019a5b85f71dfbbcb881305d2805c2ad8d5b76 Mon Sep 17 00:00:00 2001 From: Christian Davis Date: Wed, 3 Jan 2018 19:02:27 -0600 Subject: [PATCH 1/2] Update prereq yarn install level Yarn 1.0.0 contains a linking bug that is fixed in 1.3.2, creates issues otherwise: https://github.com/storybooks/storybook/issues/2382#issue-276990637 --- CONTRIBUTING.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1a6bd67a267c..0a490b8181e0 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -4,7 +4,7 @@ Thanks for your interest in improving Storybook! We are a community-driven proje Please review this document to help to streamline the process and save everyone's precious time. -This repo uses yarn workspaces, so you should `yarn@1.0.0` or higher as package manager. See [installation guide](https://yarnpkg.com/en/docs/install). +This repo uses yarn workspaces, so you should `yarn@1.3.2` or higher as package manager. See [installation guide](https://yarnpkg.com/en/docs/install). ## Issues @@ -217,7 +217,7 @@ Please have the **_latest_** stable versions of the following on your machine ### Initial Setup -If you run into trouble here, make sure your node, npm, and **_yarn_** are on the latest versions (yarn at least v1.0.0). +If you run into trouble here, make sure your node, npm, and **_yarn_** are on the latest versions (yarn at least v1.3.2). 1. `cd ~` (optional) 2. `git clone https://github.com/storybooks/storybook.git` _bonus_: use your own fork for this step @@ -296,7 +296,7 @@ If you don't see the changes rerun `yarn storybook` again in your sandbox app This section is for Storybook maintainers who will be creating releases. It assumes: -- yarn >= 1.0.0 +- yarn >= 1.3.2 - you've yarn linked `pr-log` from The current manual release sequence is as follows: @@ -360,4 +360,4 @@ npm run publish -- --concurrency 1 --force-publish=* # update the release page open https://github.com/storybooks/storybook/releases -``` \ No newline at end of file +``` From 641eac558e6bf1206051e971143eb992cb1c5c2f Mon Sep 17 00:00:00 2001 From: Christian Davis Date: Wed, 3 Jan 2018 22:14:25 -0600 Subject: [PATCH 2/2] Update yarn in engines field --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 7894635193b1..4efcdef4e6a9 100644 --- a/package.json +++ b/package.json @@ -93,7 +93,7 @@ }, "engines": { "node": ">=8.0.0", - "yarn": ">=1.0.0" + "yarn": ">=1.3.2" }, "private": true, "collective": {