Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate old keyboard shortcuts #3377

Closed
danielduan opened this issue Apr 6, 2018 · 0 comments
Closed

Deprecate old keyboard shortcuts #3377

danielduan opened this issue Apr 6, 2018 · 0 comments
Assignees
@danielduan
Labels
accessibility
Milestone
v4.0.0

Comments

@danielduan
Copy link
Member

Work summary

Keyboard shortcuts were modified so they don't conflict with browser shortcuts #1858

We should remove the old shortcuts

Where to start

https://github.com/storybooks/storybook/blob/master/lib/ui/src/libs/key_events.js#L44

Acceptance criteria

Just delete the lines that have them

Who to contact

Myself or @Hypnosphi
@danielduan danielduan added this to the v4.0.0 milestone Apr 6, 2018
@danielduan danielduan mentioned this issue Apr 6, 2018
Merged
danielduan added a commit that referenced this issue Apr 11, 2018
@danielduan
#3377 remove old keyboard shortcuts
362dda7
@danielduan danielduan mentioned this issue Apr 11, 2018
Merged
@danielduan danielduan removed the todo label Apr 11, 2018
@danielduan danielduan self-assigned this Apr 11, 2018
Hypnosphi added a commit that referenced this issue Apr 12, 2018
@Hypnosphi
Merge pull request #3402 from storybooks/dd/deprecate-shortcuts
908ac7a 
#3377 remove old keyboard shortcuts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielduan danielduan

Labels
accessibility
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
2 participants
@danielduan @Hypnosphi