Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addon-knobs: Invalid prop knob.value of type object supplied to ObjectType, expected string #1292

Closed
ranneyd opened this issue Jun 15, 2017 · 7 comments

Comments

@ranneyd
Copy link
Contributor

ranneyd commented Jun 15, 2017

When putting an object in the object knob, I get the following error:

Warning: Failed prop type: Invalid prop 'knob.value' of type 'object' supplied to 'ObjectType', expected 'string'.

I think this is related to #1265

@ranneyd ranneyd changed the title Invalid prop knob.value of type object supplied to ObjectType, expected string addon-knobs: Invalid prop knob.value of type object supplied to ObjectType, expected string Jun 15, 2017
@shilman
Copy link
Member

shilman commented Jun 15, 2017

cc @Gongreg

@Gongreg
Copy link
Member

Gongreg commented Jun 16, 2017

@shilman, we just need to go through all proptypes, since they all can be wrong.

@skaraman
Copy link

similar issue here ->

Invalid prop knob.value of type number supplied to DateType, expected string.

@SEAPUNK
Copy link

SEAPUNK commented Jun 16, 2017

Getting the same, can't wrap my head around it:

Warning: Failed prop type: Invalid prop `knob.value` of type `boolean` supplied to `BooleanType`, expected `string`.

@Gongreg
Copy link
Member

Gongreg commented Jun 19, 2017

@shilman, Can someone go through all knobs and fix proptypes?

@shilman
Copy link
Member

shilman commented Jun 21, 2017

@Gongreg @SEAPUNK @ndelangen This is fixed but has not been released yet due to a broken build on this PR:

#1303 (comment)

Looking into it now.

@ndelangen
Copy link
Member

Since we made a release in the mean time, I'm going to assume we can close this one.

This is kinda why I feel we should close issues as soon as merged..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants