From 2d78e68f0347a76773c18d81b9d562f1849ff708 Mon Sep 17 00:00:00 2001 From: Ryan Waskiewicz Date: Mon, 25 Apr 2022 10:44:38 -0400 Subject: [PATCH] chore(node12): remove node 12 from new workflows (#3344) in https://github.com/ionic-team/stencil/pull/3332, new reusable workflows were created for stencil's ci system to enable parallelism/speed. these workflows were written with stencil v2 in mind, and as a result target node v12. we removed v12 support for stencil (v3+) in https://github.com/ionic-team/stencil/pull/3302. however, upon merging `main` into `v3.0.0-dev`, we realized that we need to remove the values for node 12 from the new workflows --- .github/workflows/test-analysis.yml | 2 +- .github/workflows/test-e2e.yml | 2 +- .github/workflows/test-unit.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test-analysis.yml b/.github/workflows/test-analysis.yml index 38fc3a582de..ed5cfd13595 100644 --- a/.github/workflows/test-analysis.yml +++ b/.github/workflows/test-analysis.yml @@ -11,7 +11,7 @@ jobs: strategy: fail-fast: false matrix: - node: [ '12', '14', '16' ] + node: [ '14', '16' ] os: [ 'ubuntu-latest', 'windows-latest' ] runs-on: ${{ matrix.os }} steps: diff --git a/.github/workflows/test-e2e.yml b/.github/workflows/test-e2e.yml index 6ebc8024e36..0ef8fd75abf 100644 --- a/.github/workflows/test-e2e.yml +++ b/.github/workflows/test-e2e.yml @@ -11,7 +11,7 @@ jobs: strategy: fail-fast: false matrix: - node: [ '12', '14', '16' ] + node: [ '14', '16' ] os: [ 'ubuntu-latest', 'windows-latest' ] runs-on: ${{ matrix.os }} steps: diff --git a/.github/workflows/test-unit.yml b/.github/workflows/test-unit.yml index feb4da925dc..34eef91b913 100644 --- a/.github/workflows/test-unit.yml +++ b/.github/workflows/test-unit.yml @@ -11,7 +11,7 @@ jobs: strategy: fail-fast: false matrix: - node: [ '12', '14', '16' ] + node: [ '14', '16' ] os: [ 'ubuntu-latest', 'windows-latest' ] runs-on: ${{ matrix.os }} steps: