Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crosslink issue #482

Closed
mratsim opened this issue Oct 9, 2019 · 2 comments
Closed

Crosslink issue #482

mratsim opened this issue Oct 9, 2019 · 2 comments

Comments

@mratsim
Copy link
Contributor

mratsim commented Oct 9, 2019

After a time on the eth2 simulation we trigger one of the following crosslink message:

https://github.com/status-im/nim-beacon-chain/blob/5f271fd82e3b3093fa293c3171ccf62fa34d8009/beacon_chain/spec/beaconstate.nim#L567-L570

https://github.com/status-im/nim-beacon-chain/blob/5f271fd82e3b3093fa293c3171ccf62fa34d8009/beacon_chain/spec/beaconstate.nim#L577-L580
@tersec
Copy link
Contributor

tersec commented Oct 24, 2019

This should not be prioritized, as ethereum/consensus-specs#1428 is approved and will remove crosslinks from phase 0, unless it critically breaks a near-term testnet rather than warning.

If it's an indicator for some other underlying/more fundamental issue, fine, but if it's genuinely solely a crosslink management issue which stays somewhat isolated, spending too much time on this is a bad investment.

@tersec
Copy link
Contributor

tersec commented Oct 29, 2019

https://github.com/ethereum/eth2.0-specs/releases/tag/v0.9.0 removes crosslinks from phase 0.

@tersec tersec closed this as completed Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tersec @mratsim