Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

X-Forwarded-Prefix not working when using MVC #3354

Open
NilsEngelbach opened this issue Apr 15, 2024 · 1 comment · May be fixed by #3443
Open

X-Forwarded-Prefix not working when using MVC #3354

NilsEngelbach opened this issue Apr 15, 2024 · 1 comment · May be fixed by #3443
Labels
bug in: server-webmvc

Comments

@NilsEngelbach
Copy link
Contributor

Describe the bug
When using Spring Cloud Gateway MVC (2023.0.1) with Spring Boot (3.2.4) the forwarded requests are missing the X-Forwarded-Prefix Header. I have prepared a small comparison. The only possibility I found was setting the Header manually using the AddRequestHeader=X-Forwarded-Prefix, /foo/bar filter.

Shared Configuration

    <dependencyManagement>
        <dependencies>
            <dependency>
                <groupId>org.springframework.cloud</groupId>
                <artifactId>spring-cloud-dependencies</artifactId>
                <version>2023.0.1</version>
                <type>pom</type>
                <scope>import</scope>
            </dependency>

            <dependency>
                <groupId>org.springframework.boot</groupId>
                <artifactId>spring-boot-dependencies</artifactId>
                <version>3.2.4</version>
                <type>pom</type>
                <scope>import</scope>
            </dependency>
        </dependencies>
    </dependencyManagement>

    <dependencies>
        <dependency>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-starter</artifactId>
        </dependency>
        <dependency>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-autoconfigure</artifactId>
        </dependency>
        [...]
    </dependencies>

MVC Configuration

        <dependency>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-starter-web</artifactId>
        </dependency>
        <dependency>
            <groupId>org.springframework.cloud</groupId>
            <artifactId>spring-cloud-starter-gateway-mvc</artifactId>
        </dependency>
server:
  port: ${SERVER_PORT:8080}
  forward-headers-strategy: FRAMEWORK

spring:
  cloud:
    gateway:
      mvc:
        routes:
          - id: echo-service
            uri: <URL>
            filters:
              - StripPrefix=2
            predicates:
              - Path=/foo/bar/**

The forwarded Request ist missing the X-Forwarded-Prefix Header:

GET /baz HTTP/2.0

Host: <HOST>
X-Forwarded-For: 0:0:0:0:0:0:0:1
X-Forwarded-Host: localhost:8080
X-Forwarded-Port: 8080
X-Forwarded-Proto: http

REACTIVE Configuration

        <dependency>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-starter-webflux</artifactId>
        </dependency>
        <dependency>
            <groupId>org.springframework.cloud</groupId>
            <artifactId>spring-cloud-starter-gateway</artifactId>
        </dependency>
server:
  port: ${SERVER_PORT:8080}
  forward-headers-strategy: FRAMEWORK

spring:
  cloud:
    gateway:
      routes:
        - id: echo-service
          uri: <URL>
          filters:
            - StripPrefix=2
          predicates:
            - Path=/foo/bar/**
GET /baz HTTP/1.1

Host: <HOST>
X-Forwarded-For: 0:0:0:0:0:0:0:1
X-Forwarded-Host: localhost:8080
X-Forwarded-Port: 8080
X-Forwarded-Prefix: /foo/bar
X-Forwarded-Proto: http
@spencergibb spencergibb moved this to Todo in 2023.0.2 Apr 15, 2024
@spencergibb spencergibb modified the milestones: 4.1.3, 4.1.4 Apr 15, 2024
@ryanjbaxter ryanjbaxter removed this from 2023.0.2 Jun 10, 2024
@spencergibb spencergibb moved this to Todo in 2023.0.3 Jun 17, 2024
@jrhenderson1988 jrhenderson1988 linked a pull request Jun 30, 2024 that will close this issue
Open
@mshima mshima mentioned this issue Jul 15, 2024
Closed
1 task
@spencergibb spencergibb removed this from 2023.0.3 Oct 28, 2024
@spencergibb spencergibb modified the milestones: 4.1.4, 4.1.6 Oct 28, 2024
@spencergibb spencergibb moved this to Todo in 2023.0.4 Oct 28, 2024
@spencergibb spencergibb removed this from the 4.1.6 milestone Dec 2, 2024
@spencergibb spencergibb removed this from 2023.0.4 Dec 2, 2024
@spencergibb spencergibb moved this to Todo in 2023.0.5 Dec 2, 2024
@spencergibb spencergibb removed this from 2023.0.5 Jan 10, 2025
@spencergibb spencergibb moved this to Todo in 2023.0.6 Jan 10, 2025
@t-beckmann
Copy link

Not to be taken seriously but… https://chatgpt.com/share/67897866-2904-800b-96a3-ba43cc156776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug in: server-webmvc
Projects
2023.0.6
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: X-Forwarded-Prefix not working when using MVC jrhenderson1988/spring-cloud-gateway
3 participants
@spencergibb @t-beckmann @NilsEngelbach