Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stripPrefix is double-encoding paths #3436

Closed
rworsnop opened this issue Jun 24, 2024 · 1 comment · May be fixed by #3437
Closed

stripPrefix is double-encoding paths #3436

rworsnop opened this issue Jun 24, 2024 · 1 comment · May be fixed by #3437
Labels
waiting-for-triage

Comments

@rworsnop
Copy link

Description
This is happening in Spring Cloud Gateway Server MVC 4.1.4.
The stripPrefix filter is using the UriComponentsBuilder.build overload that defaults to encoded=false.
But by this point the URI is encoded, so this double-encodes.

Sample
See new test case in PR.
rworsnop pushed a commit to rworsnop/spring-cloud-gateway that referenced this issue Jun 24, 2024
Stop double-encoding path in stripPrefix
4c5d4f2 
Fixes spring-cloudgh-3436
@rworsnop rworsnop mentioned this issue Jun 24, 2024
Open
@spencergibb
Copy link
Member

Closing in favor of #3437

@spencergibb spencergibb closed this as not planned Won't fix, can't repro, duplicate, stale Jun 24, 2024
rworsnop pushed a commit to rworsnop/spring-cloud-gateway that referenced this issue Jun 25, 2024
Stop double-encoding path in various filters
c6083a6 
Fixes spring-cloudgh-3436
rworsnop pushed a commit to rworsnop/spring-cloud-gateway that referenced this issue Jun 25, 2024
Stop double-encoding path in various filters
1414fc4 
Fixes spring-cloudgh-3436
rworsnop pushed a commit to rworsnop/spring-cloud-gateway that referenced this issue Oct 2, 2024
Stop double-encoding path in various filters
8e3f139 
Fixes spring-cloudgh-3436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
waiting-for-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop double-encoding path in various filter functions rworsnop/spring-cloud-gateway
2 participants
@spencergibb @rworsnop