Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Additional options for Dialog component #348

Open
1 of 2 tasks
mkstowe opened this issue Aug 6, 2024 · 0 comments
Open
1 of 2 tasks

RFC: Additional options for Dialog component #348

mkstowe opened this issue Aug 6, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@mkstowe
Copy link

mkstowe commented Aug 6, 2024

Which scope/s are relevant/related to the feature request?

dialog

Information

It would be useful to have the following options in the dialog component:

  1. Hide close button - hide the 'x' icon for when we want to use our own button to close
  2. Disable close when pressing escape - similar to the existing option to disable close on backdrop click

Describe any alternatives/workarounds you're currently using

Hiding the close button can be done with CSS or DOM manipulation, but this isn't very elegant.

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@mkstowe mkstowe added the enhancement New feature or request label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant