About the PR

Uplink items that spawn impassible objects such as surplus crates or syndicate bombs will now spawn one tile in front of the player, rather than directly on the player which often displaces the player into walls.

This fix also inadvertently fixes mime walls spawning on top of players and RCD being able to deconstruct the floor under tables.

Why / Balance

Fixes #31604
Fixes #34829
Fixes #34828

When I think back on my memories of this game, the one that stands out the most is a shift I had on Oasis where I was the psychologist. I was in my office and a thief purchased an invisible crate below my office. The invisible crate pushed the player into the wall suffocating them, and since they were a new player, they did not realize they could have opened the crate to free themselves and died. I did not really have an in-character way of letting them know that it wasn't their fault, and I've wanted to fix this issue ever since.

Technical details

For the fix in the turf system, I don't really know why changing from Box2Rotated to just Box2 fixes the issue it has, but it does.

For the store UI code, the goal is to not displace any object from purchasing the item. This means checking the tile in front of the buyer and ensuring it's empty.

To do that, a dummy entity is spawned in nullspace so that we can access the components from it. If the dummy entity has any fixture with collision layers that could displace the buyer or any other mob on the tile in front of the buyer, we prevent the purchasing of the item.

Media

Before the preventative measure:

After the preventative measure:

Mime powers fix:

RCD fix:

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

• add: Crates and large objects purchased from the uplink now spawn one tile in front of the player if the tile is free.
• fix: Mime powers are now correctly blocked by mobs and walls.
• fix: RCD can no longer deconstruct tiles that are occupied.