Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid selecting all guide stars in one quadrant #206

Open
taldcroft opened this issue Dec 20, 2018 · 4 comments
Open

Avoid selecting all guide stars in one quadrant #206

taldcroft opened this issue Dec 20, 2018 · 4 comments
Labels

Comments

@taldcroft
Copy link
Member

For obsids like 20433 proseco has chosen a guide catalog with all stars in one quadrant. This is acceptable but should be avoided when possible.

@jeanconn
Copy link
Contributor

I'm not as sure about the generalization. For example, I think one star away from the cluster has a potential to increase dr95. If we want to look at putting back the figure-of-merit optimization we can, but I'm was hoping to skip ahead to annie-lite-style optimization.

@jeanconn
Copy link
Contributor

jeanconn commented Feb 6, 2019

This issue is not (explicitly) fixed by #258 . Should I add another "check" that the stars aren't all in one quadrant as part of the optimization?

@jeanconn
Copy link
Contributor

jeanconn commented Feb 7, 2019

I'll add this check as a separate PR and then we can decide to merge or not after evaluating impact.

@taldcroft
Copy link
Member Author

Not for 4.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants