Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown packs #52

Open
kriki200 opened this issue Nov 4, 2024 · 4 comments
Open

Unknown packs #52

kriki200 opened this issue Nov 4, 2024 · 4 comments

Comments

@kriki200
Copy link

kriki200 commented Nov 4, 2024

YOu could add an unkown packs option, that would keep a counter on the new expansion packs, before they are aded, and maybe transfer the statistics onto the packs when they're added (would be okay even if they weren't as you'd at least know what pack you're on).

@sgkoishi
Copy link
Owner

sgkoishi commented Nov 4, 2024

That's the default behaviour: all unknown packs have their unique id (usually a three digit number) which will be used for stats. Most of the recent updates of this plugin are just adding translation for those ids.
If it fails to detect new packs there's probably something wrong with HDT I guess?

@Westwoodmayim
Copy link

Westwoodmayim commented Nov 5, 2024

That's the default behaviour: all unknown packs have their unique id (usually a three digit number) which will be used for stats. Most of the recent updates of this plugin are just adding translation for those ids. If it fails to detect new packs there's probably something wrong with HDT I guess?

That's also OK but a bit suggestion:
Unknown card packs will also be listed in the selector (ID only) instead of being hidden, so we can check pity timer/statistic any time ( e.g. when new expansion is available ) and no need to wait for the plugin update xD

@sgkoishi
Copy link
Owner

sgkoishi commented Nov 6, 2024

image
It should be the default behaviour too, just like the previous version... lemme check if something goes wrong

@kriki200
Copy link
Author

kriki200 commented Nov 6, 2024

That's the default behaviour: all unknown packs have their unique id (usually a three digit number) which will be used for stats. Most of the recent updates of this plugin are just adding translation for those ids. If it fails to detect new packs there's probably something wrong with HDT I guess?

Oh thanks, it started working after I made the post, hasn't worked for any previous expansions, so it might've been a HDT error :) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants