Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't sign out #131

Open
budak7273 opened this issue Nov 25, 2023 · 1 comment · May be fixed by #209
Open

Can't sign out #131

budak7273 opened this issue Nov 25, 2023 · 1 comment · May be fixed by #209
Labels
bug Something isn't working

Comments

@budak7273
Copy link
Member

budak7273 commented Nov 25, 2023 •
edited
Loading

To reproduce:

  1. Sign into an account
  2. Log out
  3. The site makes it appear you have logged out
  4. Try to log in again
  5. GraphQL error, user already signed in
  6. Try to log out again
  7. Nav to another page or force refresh
  8. You're still logged in

Only tested on ficsit.app, didn't try on ficsit.dev

Workaround: delete your token cookie
@budak7273 budak7273 added the bug Something isn't working label Nov 25, 2023
@budak7273 budak7273 moved this to 📋 Backlog in Mod Repository (SMR) Nov 25, 2023
@budak7273
Copy link
Member Author

Caused by clearing the svelte store but not the cookie https://discord.com/channels/555424930502541343/830842478956642354/1190051379188871281

joshuata added a commit to joshuata/smr-frontend that referenced this issue Nov 15, 2024
@joshuata
fix(auth): can't sign out
62da3db 
Fixes satisfactorymodding#131. Explicitly setting the cookie hostname was causing
cookie.remove to fail.

I cannot fully test this fix since I cannot test oauth on my machine,
but I haven't changed any logic so it should be a quick validation.
@joshuata joshuata linked a pull request Nov 15, 2024 that will close this issue
Open
joshuata added a commit to joshuata/smr-frontend that referenced this issue Nov 16, 2024
@joshuata
fix(auth): can't sign out
abdfade 
Fixes satisfactorymodding#131. Explicitly setting the cookie hostname was causing
cookie.remove to fail.

I cannot fully test this fix since I cannot test oauth on my machine,
but I haven't changed any logic so it should be a quick validation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Mod Repository (SMR)
Status: 📋 Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(auth): can't sign out joshuata/smr-frontend
1 participant
@budak7273