-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the 1.3.0 singleton addresses deployed with safe singleton factory as supported networks #519
Comments
@hectorgomezv @fmrsabino we will have master copies with duplicated |
So instead of having unique I'd appreciate a second review by @fmrsabino but AFAIK it shouldn't be a problem if that's the case, the Client Gateway doesn't contain any associated logic for parsing/validating the master copies' uniqueness. |
@Uxio0 Could you give an example on what you mean by duplicated version? |
In the [
{
"address": "0x3E5c63644E683549055b9Be8653de26E0B4CD36E",
"version": "1.3.0+L2",
"deployer": "Gnosis",
"deployedBlockNumber": 12504423,
"lastIndexedBlockNumber": 17179203,
"l2": true
},
{
"address": "0xfb1bffC9d739B8D520DaF37dF666da4C687191EA",
"version": "1.3.0+L2",
"deployer": "Gnosis",
"deployedBlockNumber": 12504423,
"lastIndexedBlockNumber": 17179203,
"l2": true
}
] |
@Uxio0 Just confirmed with mobile and web. This change shouldn't affect the client-side either. Good to go also on the service side! |
|
Commenting here to suggest updating the table above to include factory+singleton deployments now live on Arbitrum... singleton: https://optimistic.etherscan.io/address/0xfb1bffC9d739B8D520DaF37dF666da4C687191EA factory: https://optimistic.etherscan.io/address/0xC22834581EbC8527d974F8a1c97E1bEA4EF910BC |
But you are sharing optimism links |
After check in arbitrum, you are right, sharing the correct links: Thanks for the heads up. :) |
@moisses89 - i am still unable to access the Safe app on arbitrum which were created with this factory/singleton above.
|
The Safe is not processed as it hasn't been initialized. There are no owners and |
What is needed?
We would like to add the 1.3.0 singleton addresses deployed with the safe singleton factory as supported networks. (singleton addresses)
Also it is required that every address version 1.3.0 that wasn't deployed with the safe singleton factory and was deployed with the default singleton factory were included here. This is being solved on 1.4.0 safe-global/safe-smart-account#460
Motivation
The motivation of this is that all available addresses on every network work with our service.
Deployed using Safe singleton factory
Deployed using default singleton factory
The text was updated successfully, but these errors were encountered: