Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the 1.3.0 singleton addresses deployed with safe singleton factory as supported networks #519

Closed
moisses89 opened this issue Apr 25, 2023 · 11 comments
Assignees
Labels
breaking_change Breaking change enhancement New feature or request

Comments

@moisses89
Copy link
Member

moisses89 commented Apr 25, 2023

What is needed?

We would like to add the 1.3.0 singleton addresses deployed with the safe singleton factory as supported networks. (singleton addresses)
Also it is required that every address version 1.3.0 that wasn't deployed with the safe singleton factory and was deployed with the default singleton factory were included here. This is being solved on 1.4.0 safe-global/safe-smart-account#460

Motivation

The motivation of this is that all available addresses on every network work with our service.

Deployed using Safe singleton factory

Contract Address mainnet goerli polygon optimism Gnosis-chain arbitrum one bnb aurora avalanche CELO Base
GnosisSafe 0x69f4D1788e39c87893C980c06EdF4b7f686e2938 NO DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED DEPLOYED DEPLOYED
GnosisSafeL2 0xfb1bffC9d739B8D520DaF37dF666da4C687191EA DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED DEPLOYED DEPLOYED
GnosisSafeProxyFactory 0xC22834581EbC8527d974F8a1c97E1bEA4EF910BC DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED DEPLOYED DEPLOYED
CompatibilityFallbackHandler 0x017062a1dE2FE6b99BE3d9d37841FeD19F573804 NO DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED DEPLOYED DEPLOYED
MultiSend 0x998739BFdAAdde7C933B942a68053933098f9EDa NO DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED DEPLOYED DEPLOYED
MultiSendCallOnly 0xA1dabEF33b3B82c7814B6D82A79e50F4AC44102B NO DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED DEPLOYED DEPLOYED
CreateCall 0xB19D6FFc2182150F8Eb585b79D4ABcd7C5640A9d NO DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED DEPLOYED DEPLOYED
SignMessageLib 0x98FFBBF51bb33A056B08ddf711f289936AafF717 NO DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED DEPLOYED DEPLOYED
SimulateTxAccessor 0x727a77a074D1E6c4530e814F89E618a3298FC044 NO DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED DEPLOYED DEPLOYED
DefaultCallbackHandler 0x3d8E605B02032A941Cfe26897Ca94d77a5BC24b3 NO DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED DEPLOYED DEPLOYED

Deployed using default singleton factory

Contract Address mainnet goerli polygon optimism Gnosis-chain arbitrum one bnb aurora avalanche Celo Base
GnosisSafe 0xd9Db270c1B5E3Bd161E8c8503c55cEABeE709552 DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED NO DEPLOYED NO DEPLOYED
GnosisSafeL2 0x3E5c63644E683549055b9Be8653de26E0B4CD36E DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED NO DEPLOYED NO DEPLOYED
GnosisSafeProxyFactory 0xa6B71E26C5e0845f74c812102Ca7114b6a896AB2 DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED NO DEPLOYED NO DEPLOYED
CompatibilityFallbackHandler 0xf48f2B2d2a534e402487b3ee7C18c33Aec0Fe5e4 DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED NO DEPLOYED NO DEPLOYED
MultiSend 0xA238CBeb142c10Ef7Ad8442C6D1f9E89e07e7761 DEPLOYED DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED NO DEPLOYED NO DEPLOYED
MultiSendCallOnly 0x40A2aCCbd92BCA938b02010E17A5b8929b49130D DEPLOYED DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED NO DEPLOYED NO DEPLOYED
CreateCall 0x7cbB62EaA69F79e6873cD1ecB2392971036cFAa4 DEPLOYED DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED NO DEPLOYED NO DEPLOYED
SignMessageLib 0xA65387F16B013cf2Af4605Ad8aA5ec25a2cbA3a2 DEPLOYED DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED NO DEPLOYED NO DEPLOYED NO DEPLOYED
SimulateTxAccessor 0x59AD6735bCd8152B84860Cb256dD9e96b85F69Da DEPLOYED DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED NO DEPLOYED NO DEPLOYED
DefaultCallbackHandler 0x1AC114C2099aFAf5261731655Dc6c306bFcd4Dbd DEPLOYED DEPLOYED DEPLOYED NO DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED DEPLOYED NO DEPLOYED NO DEPLOYED
@moisses89 moisses89 added the enhancement New feature or request label Apr 25, 2023
@Uxio0
Copy link
Member

Uxio0 commented Apr 25, 2023

@hectorgomezv @fmrsabino we will have master copies with duplicated version for some addresses, just wanted to make sure it doesn't affect the client gateway

@moisses89 moisses89 self-assigned this May 2, 2023
@hectorgomezv
Copy link
Member

hectorgomezv commented May 2, 2023

@hectorgomezv @fmrsabino we will have master copies with duplicated version for some addresses, just wanted to make sure it doesn't affect the client gateway

So instead of having unique address-version pairs, the Transaction Service will respond with several items having the same version (one for each address), right?

I'd appreciate a second review by @fmrsabino but AFAIK it shouldn't be a problem if that's the case, the Client Gateway doesn't contain any associated logic for parsing/validating the master copies' uniqueness.

@fmrsabino
Copy link
Contributor

@hectorgomezv @fmrsabino we will have master copies with duplicated version for some addresses, just wanted to make sure it doesn't affect the client gateway

@Uxio0 Could you give an example on what you mean by duplicated version?

@Uxio0
Copy link
Member

Uxio0 commented May 3, 2023

@Uxio0 Could you give an example on what you mean by duplicated version?

In the /api/v1/about/master-copies/ endpoint on the transaction service we could have something like:

[
{
"address": "0x3E5c63644E683549055b9Be8653de26E0B4CD36E",
"version": "1.3.0+L2",
"deployer": "Gnosis",
"deployedBlockNumber": 12504423,
"lastIndexedBlockNumber": 17179203,
"l2": true
},
{
"address": "0xfb1bffC9d739B8D520DaF37dF666da4C687191EA",
"version": "1.3.0+L2",
"deployer": "Gnosis",
"deployedBlockNumber": 12504423,
"lastIndexedBlockNumber": 17179203,
"l2": true
}
]

@fmrsabino
Copy link
Contributor

@Uxio0 Just confirmed with mobile and web. This change shouldn't affect the client-side either. Good to go also on the service side!

@Uxio0
Copy link
Member

Uxio0 commented May 3, 2023

SafeL2 and ProxyFactory were added to the production mainnet transaction service (via admin), and it's already synced. We will add the rest by this issue and writing a migration on the tx service

@Uxio0 Uxio0 added the breaking_change Breaking change label May 3, 2023
@wavey0x
Copy link

wavey0x commented May 8, 2023

Commenting here to suggest updating the table above to include factory+singleton deployments now live on Arbitrum...

singleton: https://optimistic.etherscan.io/address/0xfb1bffC9d739B8D520DaF37dF666da4C687191EA

factory: https://optimistic.etherscan.io/address/0xC22834581EbC8527d974F8a1c97E1bEA4EF910BC

@moisses89
Copy link
Member Author

Commenting here to suggest updating the table above to include factory+singleton deployments now live on Arbitrum...

singleton: https://optimistic.etherscan.io/address/0xfb1bffC9d739B8D520DaF37dF666da4C687191EA

factory: https://optimistic.etherscan.io/address/0xC22834581EbC8527d974F8a1c97E1bEA4EF910BC

But you are sharing optimism links

@moisses89
Copy link
Member Author

Commenting here to suggest updating the table above to include factory+singleton deployments now live on Arbitrum...
singleton: https://optimistic.etherscan.io/address/0xfb1bffC9d739B8D520DaF37dF666da4C687191EA
factory: https://optimistic.etherscan.io/address/0xC22834581EbC8527d974F8a1c97E1bEA4EF910BC

But you are sharing optimism links

After check in arbitrum, you are right, sharing the correct links:
safe singleton address for gnosisSafeL2 https://arbiscan.io/address/0xfb1bffC9d739B8D520DaF37dF666da4C687191EA#code
safe singleton address for SafeProxyFactory https://arbiscan.io/address/0xC22834581EbC8527d974F8a1c97E1bEA4EF910BC#code

Thanks for the heads up. :)

@wavey0x
Copy link

wavey0x commented May 22, 2023

@moisses89 - i am still unable to access the Safe app on arbitrum which were created with this factory/singleton above.
Here is an example safe:

0x4444AAAA39E52dE39487Ef9561FCe79b154b5cCB

@Uxio0
Copy link
Member

Uxio0 commented May 22, 2023

0x4444AAAA39E52dE39487Ef9561FCe79b154b5cCB

The Safe is not processed as it hasn't been initialized. There are no owners and threshold=0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change Breaking change enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants