From 43277d746a4c75bb8e68935a5152d67ee88fb306 Mon Sep 17 00:00:00 2001 From: Koichi ITO Date: Thu, 27 Oct 2022 12:04:41 +0900 Subject: [PATCH] Cut 2.17.2 --- CHANGELOG.md | 2 ++ docs/antora.yml | 2 +- docs/modules/ROOT/pages/cops_rails.adoc | 30 +++---------------------- lib/rubocop/rails/version.rb | 2 +- relnotes/v2.17.2.md | 12 ++++++++++ 5 files changed, 19 insertions(+), 29 deletions(-) create mode 100644 relnotes/v2.17.2.md diff --git a/CHANGELOG.md b/CHANGELOG.md index 5013a669d4..01b4616c7f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,8 @@ ## master (unreleased) +## 2.17.2 (2022-10-27) + ### Bug fixes * [#825](https://github.com/rubocop/rubocop-rails/issues/825): Fix a false positive for `Rails/ActionControllerFlashBeforeRender` when using condition before `redirect_to`. ([@koic][]) diff --git a/docs/antora.yml b/docs/antora.yml index 9e0ff48acb..f804e59817 100644 --- a/docs/antora.yml +++ b/docs/antora.yml @@ -2,6 +2,6 @@ name: rubocop-rails title: RuboCop Rails # We always provide version without patch here (e.g. 1.1), # as patch versions should not appear in the docs. -version: ~ +version: '2.17' nav: - modules/ROOT/nav.adoc diff --git a/docs/modules/ROOT/pages/cops_rails.adoc b/docs/modules/ROOT/pages/cops_rails.adoc index 766004f40c..ff587f9013 100644 --- a/docs/modules/ROOT/pages/cops_rails.adoc +++ b/docs/modules/ROOT/pages/cops_rails.adoc @@ -7,7 +7,7 @@ | Pending | Yes -| Yes +| Yes (Unsafe) | 2.16 | - |=== @@ -41,16 +41,6 @@ class HomeController < ApplicationController end ---- -=== Configurable attributes - -|=== -| Name | Default value | Configurable values - -| SafeAutocorrect -| `false` -| Boolean -|=== - === References * https://rails.rubystyle.guide/#flash-before-render @@ -63,7 +53,7 @@ end | Pending | Yes -| Yes +| Yes (Unsafe) | 2.14 | - |=== @@ -95,10 +85,6 @@ end |=== | Name | Default value | Configurable values -| SafeAutocorrect -| `false` -| Boolean - | Include | `+**/test/**/*.rb+` | Array @@ -5039,7 +5025,7 @@ Rails.public_path.join('path', to, 'file.pdf') | Pending | Yes -| Yes +| Yes (Unsafe) | 2.16 | - |=== @@ -5078,16 +5064,6 @@ Rails.root.join('db', 'schema.rb').write(content) Rails.root.join('db', 'schema.rb').binwrite(content) ---- -=== Configurable attributes - -|=== -| Name | Default value | Configurable values - -| SafeAutocorrect -| `false` -| Boolean -|=== - == Rails/RootPublicPath |=== diff --git a/lib/rubocop/rails/version.rb b/lib/rubocop/rails/version.rb index 6a0de28506..c408f6914d 100644 --- a/lib/rubocop/rails/version.rb +++ b/lib/rubocop/rails/version.rb @@ -4,7 +4,7 @@ module RuboCop module Rails # This module holds the RuboCop Rails version information. module Version - STRING = '2.17.1' + STRING = '2.17.2' def self.document_version STRING.match('\d+\.\d+').to_s diff --git a/relnotes/v2.17.2.md b/relnotes/v2.17.2.md new file mode 100644 index 0000000000..452dbf4384 --- /dev/null +++ b/relnotes/v2.17.2.md @@ -0,0 +1,12 @@ +### Bug fixes + +* [#825](https://github.com/rubocop/rubocop-rails/issues/825): Fix a false positive for `Rails/ActionControllerFlashBeforeRender` when using condition before `redirect_to`. ([@koic][]) +* [#833](https://github.com/rubocop/rubocop-rails/issues/833): Fix a false positive for `Rails/Pluck` when receiver is not block argument for `[]`. ([@koic][]) +* [#834](https://github.com/rubocop/rubocop-rails/issues/834): Fix an error for `Rails/WhereNotWithMultipleConditions` when using `where.not` with empty hash literal. ([@koic][]) +* [#833](https://github.com/rubocop/rubocop-rails/issues/833): Fix a false positive for `Rails/Pluck` when using multiple block arguments. ([@koic][]) + +### Changes + +* [#832](https://github.com/rubocop/rubocop-rails/issues/832): Mark `Rails/ActionControllerFlashBeforeRender`, `Rails/ActionControllerTestCase`, and `Rails/RootPathnameMethods` cops as unsafe autocorrection. ([@koic][]) + +[@koic]: https://github.com/koic