Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Himalayas #784

Merged
merged 10 commits into from
Jan 9, 2025
Merged

Himalayas #784

merged 10 commits into from
Jan 9, 2025

Conversation

nicolasfoss
Copy link
Contributor

Thank you for your submission! Please leave this text as-is when you submit, and then check the checklist.

Usability:

  • This dataset has not already been used in TidyTuesday.
  • The dataset is less than 20MB when saved as a tidy CSV.
  • I can imagine at least one data visualization related to this dataset.

Preparation:

  • cleaning.R has code to download and clean the dataset, resulting in descriptively-named data.frames.
  • I ran saving.R to create csvs and md data dictionaries for each of my data.frames.
  • I filled in descriptions for each variable in each of the {dataset}.md files.
  • I edited the intro.md file to introduce my dataset.
  • I included at least one image for my dataset as a png file.
  • I completed the information in meta.yaml, including descriptive alt text for each image.
  • I provided information in meta.yaml about how to credit me, and deleted any parts of that block that I do not want you to use.

@nicolasfoss
Copy link
Contributor Author

I was thinking maybe the analysis would be more interesting if I provide the dataset that has all the climber information as well?

Copy link
Collaborator

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple tweaks. I'll apply them then make sure everything merges cleanly. Thanks!

data/curated/himalayas/meta.yaml Outdated Show resolved Hide resolved
data/curated/himalayas/meta.yaml Outdated Show resolved Hide resolved
data/curated/himalayas/intro.md Outdated Show resolved Hide resolved
@jonthegeek
Copy link
Collaborator

Note to self: make sure credit still shows up properly after this is assigned:

Thank you to [Nicolas Foss](www.linkedin.com/in/nicolas-foss) for curating this week's dataset.

Copy link
Collaborator

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Now I just need to assign it to a week and see if that reveals any issues.

@jonthegeek
Copy link
Collaborator

/assign positconf 2025-01-21

@jonthegeek
Copy link
Collaborator

/assign himalayas 2025-01-21

Copy link
Collaborator

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update credit link

data/2025/2025-01-21/readme.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@jonthegeek jonthegeek merged commit 3cdd8af into rfordatascience:main Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants