Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created content for pull request for TT - Fragrance Dataset #776

Merged
merged 13 commits into from
Nov 26, 2024

Conversation

nicolasfoss
Copy link
Contributor

@nicolasfoss nicolasfoss commented Nov 25, 2024

Thank you for your submission! Please leave this text as-is when you submit, and then check the checklist.

Usability:

  • This dataset has not already been used in TidyTuesday.
  • The dataset is less than 20MB when saved as a tidy CSV.
  • I can imagine at least one data visualization related to this dataset.

Preparation:

  • cleaning.R has code to download and clean the dataset, resulting in descriptively-named data.frames.
  • I ran saving.R to create csvs and md data dictionaries for each of my data.frames.
  • I filled in descriptions for each variable in each of the {dataset}.md files.
  • I edited the intro.md file to introduce my dataset.
  • I included at least one image for my dataset as a png file.
  • I completed the information in meta.yaml, including descriptive alt text for each image.
  • I provided information in meta.yaml about how to credit me, and deleted any parts of that block that I do not want you to use.

@jonthegeek
Copy link
Collaborator

jonthegeek commented Nov 25, 2024

@nicolasfoss Thank you so much for the submission! I'll review it later today!

FYI, on GitHub you can use an empty pair of square brackets in a bulleted list (like this - [ ] for an interactive checkbox, or you can fill it in with an x like - [x] for a checked box. I should probably spell that out in the template! Then GitHub tracks the items as "to-do" for that particular issue or PR. Eg:

  • Describe how checkboxes work.
  • Write a ticket to clean up the PR instructions.

@nicolasfoss
Copy link
Contributor Author

I wondered about that!

I will do that for the Dr. Nick dataset. I will probably submit that next week sometime.

Thanks for all the instructions. It made everything easy to use. I use GitHub desktop so that's the route I went but it's basically the same thing.

@nicolasfoss
Copy link
Contributor Author

nicolasfoss commented Nov 25, 2024

@jonthegeek I fixed the checkboxes for good measure.

Have a great day!

@jonthegeek
Copy link
Collaborator

@jonthegeek I fixed the checkboxes for good measure.

Isn't it more satisfying that way? 😁

Thanks for the submission(s)! I'm trying to "finish" dataset curation for the year within the next few days, and your Dr. Nick dataset will leave just 1 more (besides the one I'm working on)! 🎉

Copy link
Collaborator

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few tweaks. I'll apply the changes myself, then assign this to a week. Thanks again!

data/curated/parfumo_fragrance/cleaning.R Outdated Show resolved Hide resolved
data/curated/parfumo_fragrance/intro.md Outdated Show resolved Hide resolved
data/curated/parfumo_fragrance/intro.md Outdated Show resolved Hide resolved
@jonthegeek
Copy link
Collaborator

/assign parfumo_fragrance 2024-12-10

@jonthegeek
Copy link
Collaborator

Oh, not quite! Please don't delete sections of the meta.yaml file! I'm adding an article (which really means "anything that talks about the data", so https://www.parfumo.com/Perfumes works), and making sure nothing else is missing.

Copy link
Collaborator

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be ready for assigning to a date now!

@jonthegeek
Copy link
Collaborator

/assign parfumo_fragrance 2024-12-10

Copy link
Collaborator

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will do it. Thanks!

README.md Outdated Show resolved Hide resolved
data/2024/2024-12-10/meta.yaml Outdated Show resolved Hide resolved
data/2024/readme.md Outdated Show resolved Hide resolved
@jonthegeek jonthegeek merged commit d0536f3 into rfordatascience:master Nov 26, 2024
@jonthegeek jonthegeek mentioned this pull request Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants