feat: remove Node.FS.Sync.fdFlush

Author: srghma

CHANGELOG.md

@@ -8,7 +8,7 @@ Breaking changes:
 
 New features:
 
-- Add functions to `Node.FS.Async`
+- Add functions to `Node.FS.Async`, `Node.FS.Aff`, `Node.FS.Sync`
 
   - readdir'
   - readdirBuffer
@@ -39,29 +39,7 @@ New features:
   - statfs
   - writev
 
-- Add functions to `Node.FS.Aff`
-
-  - cp
-  - cp'
-  - fchmod
-  - fchown
-  - fdatasync
-  - fstat
-  - fsync
-  - ftruncate
-  - futimes
-  - glob
-  - glob'
-  - globDirent
-  - globDirent'
-  - lchmod
-  - lchown
-  - lutimes
-  - opendir
-  - opendir'
-  - readv
-  - statfs
-  - writev
+- Deprecate `Node.FS.Sync.fdFlush`, `Node.FS.Sync.fsync` should be used instead
 
 - Add modules `Dir`, `Dir.Aff`, `Dirent`
 

src/Node/FS/Sync.purs

@@ -52,7 +52,6 @@ module Node.FS.Sync
   , fdWrite'
   , fdWriteString
   , fdAppend
-  , fdFlush
   , fdClose
   , cp
   , cp'
@@ -101,7 +100,6 @@ import Node.FS.Internal.Utils (datetimeToUnixEpochTimeInSeconds)
 import Node.FS.Perms (Perms, permsToString)
 import Node.FS.Stats (Stats)
 import Node.Path (FilePath)
-import Prim.TypeError (class Warn, Text)
 import Unsafe.Coerce (unsafeCoerce)
 
 foreign import accessSyncImpl :: EffectFn2 FilePath AccessMode Unit
@@ -526,11 +524,6 @@ fdAppend fd buff = do
   sz <- size buff
   fdWrite fd buff 0 sz Nothing
 
--- | Flush a file synchronously.  See the [Node documentation](http://nodejs.org/api/fs.html#fs_fs_fsyncsync_fd)
--- | for details.
-fdFlush :: Warn (Text "Deprecated, use fsync") => FileDescriptor -> Effect Unit
-fdFlush = fsync
-
 -- | Close a file synchronously. See the [Node documentation](http://nodejs.org/api/fs.html#fs_fs_closesync_fd)
 -- | for details.
 fdClose :: FileDescriptor -> Effect Unit

test/Test/Node/FS/Sync.purs

@@ -153,7 +153,7 @@ main = do
   fd0 <- S.fdOpen fdFile W (Just 420)
   buf0 <- Buffer.fromString "[ 42 ]" UTF8
   _bytes0 <- S.fdAppend fd0 buf0
-  S.fdFlush fd0
+  S.fsync fd0
   S.fdClose fd0
   fd1 <- S.fdOpen fdFile R Nothing
   buf1 <- Buffer.create =<< Buffer.size buf0