fix: TypeError [ERR_INVALID_ARG_TYPE]: The "options.filter" property must be of type function. Received null

Author: srghma

spago.lock

@@ -143,7 +143,7 @@
     },
     "package_set": {
       "address": {
-        "registry": "60.3.0"
+        "registry": "60.5.0"
       },
       "compiler": ">=0.15.15 <0.16.0",
       "content": {
@@ -358,6 +358,7 @@
         "js-promise-aff": "1.0.0",
         "js-timers": "6.1.0",
         "js-uri": "3.1.0",
+        "jsdom": "1.0.0",
         "json": "1.1.0",
         "json-codecs": "5.0.0",
         "justifill": "0.5.0",
@@ -547,8 +548,8 @@
         "soundfonts": "4.1.0",
         "sparse-matrices": "2.0.1",
         "sparse-polynomials": "3.0.1",
-        "spec": "8.0.0",
-        "spec-discovery": "8.3.0",
+        "spec": "8.1.0",
+        "spec-discovery": "8.4.0",
         "spec-mocha": "5.1.1",
         "spec-node": "0.0.2",
         "spec-quickcheck": "5.0.2",

spago.yaml

@@ -40,5 +40,5 @@ package:
       - node-event-emitter
 workspace:
   packageSet:
-    registry: 60.3.0
+    registry: 60.5.0
   extraPackages: {}

src/Node/FS/Internal/Undefinable.js

@@ -0,0 +1,12 @@
+/* eslint-disable no-eq-null, eqeqeq */
+
+const undefinedImpl = undefined;
+export { undefinedImpl as undefined };
+
+export function undefinable(a, r, f) {
+  return a === undefined ? r : f(a);
+}
+
+export function notUndefined(x) {
+  return x;
+}

src/Node/FS/Internal/Undefinable.purs

@@ -0,0 +1,55 @@
+-- | This module defines types and functions for working with undefinable types
+-- | using the FFI.
+
+module Node.FS.Internal.Undefinable
+  ( Undefinable
+  , undefined
+  , notUndefined
+  , toMaybe
+  , toUndefinable
+  ) where
+
+import Prelude
+
+import Data.Eq (class Eq1)
+import Data.Function (on)
+import Data.Function.Uncurried (Fn3, runFn3)
+import Data.Maybe (Maybe(..), maybe)
+import Data.Ord (class Ord1)
+
+foreign import data Undefinable :: Type -> Type
+
+type role Undefinable representational
+
+-- | The undefined value.
+foreign import undefined :: forall a. Undefinable a
+
+foreign import undefinable :: forall a r. Fn3 (Undefinable a) r (a -> r) r
+
+-- | Wrap a non-undefined value.
+foreign import notUndefined :: forall a. a -> Undefinable a
+
+-- | Takes `Nothing` to `undefined`, and `Just a` to `a`.
+toUndefinable :: forall a. Maybe a -> Undefinable a
+toUndefinable = maybe undefined notUndefined
+
+-- | Represent `undefined` using `Maybe a` as `Nothing`. Note that this function
+-- | can violate parametricity, as it inspects the runtime representation of
+-- | its argument (see the warning about the pitfall of `Undefinable` above).
+toMaybe :: forall a. Undefinable a -> Maybe a
+toMaybe n = runFn3 undefinable n Nothing Just
+
+instance showUndefinable :: Show a => Show (Undefinable a) where
+  show = maybe "undefined" show <<< toMaybe
+
+instance eqUndefinable :: Eq a => Eq (Undefinable a) where
+  eq = eq `on` toMaybe
+
+instance eq1Undefinable :: Eq1 Undefinable where
+  eq1 = eq
+
+instance ordUndefinable :: Ord a => Ord (Undefinable a) where
+  compare = compare `on` toMaybe
+
+instance ord1Undefinable :: Ord1 Undefinable where
+  compare1 = compare

src/Node/FS/Options.purs

@@ -1,6 +1,5 @@
 module Node.FS.Options where
 
-import Node.FS.Types (BufferLength, BufferOffset, EncodingString, FileMode, FilePosition)
 import Prelude
 
 import Data.Function.Uncurried (Fn2, mkFn2)
@@ -13,7 +12,10 @@ import Node.Buffer (Buffer)
 import Node.Encoding (Encoding(..), encodingToNode)
 import Node.FS.Constants (FileFlags(..), fileFlagsToNode)
 import Node.FS.Dirent (Dirent, DirentNameTypeString)
+import Node.FS.Internal.Undefinable (Undefinable)
+import Node.FS.Internal.Undefinable as Undefinable
 import Node.FS.Perms (Perms, all, mkPerms, permsToString, read, write)
+import Node.FS.Types (BufferLength, BufferOffset, EncodingString, FileMode, FilePosition)
 import Node.Path (FilePath)
 
 type RmdirOptions = { maxRetries :: Int, retryDelay :: Int }
@@ -249,7 +251,8 @@ fdWriteOptionsToInternal { offset, length, position } = { offset, length: Nullab
 type CpOptionsInternal =
   { dereference :: Boolean
   , errorOnExist :: Boolean
-  , filter :: Nullable (Fn2 FilePath FilePath Boolean)
+  -- if null - will throw "TypeError [ERR_INVALID_ARG_TYPE]: The "options.filter" property must be of type function. Received null"
+  , filter :: Undefinable (Fn2 FilePath FilePath Boolean)
   , force :: Boolean
   , mode :: FileMode
   , preserveTimestamps :: Boolean
@@ -286,7 +289,7 @@ cpOptionsToCpOptionsInternal opts =
   , errorOnExist: case opts.force of
       CpForce_TrueWithErrorOnExit -> true
       _ -> false
-  , filter: toNullable $ map mkFn2 (opts.filter)
+  , filter: Undefinable.toUndefinable $ map mkFn2 (opts.filter)
   , force: case opts.force of
       CpForce_False -> false
       _ -> true
@@ -326,4 +329,3 @@ opendirOptionsDefault = { bufferSize: 32, recursive: false, encoding: UTF8 }
 
 opendirOptionsToInternal :: OpendirOptions -> OpendirOptionsInternal
 opendirOptionsToInternal { encoding, bufferSize, recursive } = { encoding: encodingToNode encoding, bufferSize, recursive }
-