Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make action run statuses clearer #892

Open
gabestein opened this issue Jan 12, 2025 · 0 comments
Open

Make action run statuses clearer #892

gabestein opened this issue Jan 12, 2025 · 0 comments
Assignees
Labels

Comments

@gabestein
Copy link
Member

gabestein commented Jan 12, 2025

I think I remember having this discussion and I get why we did this — action ran successfully, with unintended result, vs. action failed to run at all — but in practice I'm finding this is bad UX, because an action failing to have the intended effect is the same thing as the action not running at all in the user's mind and in a practical workflow.

I think we should show some kind of error when an action run doesn't have the expected result — either because it doesn't run at all, or because it didn't have the result the author of the action intended. Very open to how we show and, if needed, distinguish between these errors to the user. It's fine if we don't distinguish at all to the user.

This return (googleDriveImport/run.ts):

		} catch (err) {
			logger.error(err);

			return {
				title: "Error",
				error: err.title,
			};
		}

Generates this:
Image

@gabestein gabestein converted this from a draft issue Jan 12, 2025
@gabestein gabestein changed the title Don't show action run success if it returns an error Make action run statuses clearer Jan 12, 2025
@gabestein gabestein moved this from Ready to In Progress in PubPub Legacy & Platform Combined Workstreams Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

2 participants