Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue error when there is unnecessary space around dot #288

Closed
hmhagberg opened this issue Oct 5, 2018 · 6 comments
Closed

Issue error when there is unnecessary space around dot #288

hmhagberg opened this issue Oct 5, 2018 · 6 comments

Comments

@hmhagberg
Copy link

For example, both lines below are fine according to ktlint 0.27

fun String . foo() = "foo"
" " . foo()

I would expect there to be an error, with the correct form being

fun String.foo() = "foo"
" ".foo()
@shyiko
Copy link
Collaborator

shyiko commented Oct 5, 2018

Thanks. Apparently we need something similar to SpacingAroundCommaRule.

@AleksandrSl
Copy link
Contributor

Can I take this one?

@shyiko
Copy link
Collaborator

shyiko commented Oct 5, 2018

@AleksandrSl that would be great!

@AleksandrSl
Copy link
Contributor

#293

@AleksandrSl AleksandrSl mentioned this issue Oct 13, 2018
Merged
shyiko added a commit that referenced this issue Oct 13, 2018
@shyiko
Merge pull request #293 from AleksandrSl/feature/#288
dbc591e 
Add rule for dot spacing #288
@cable729
Copy link
Contributor

This should be closed

@shyiko
Copy link
Collaborator

shyiko commented Oct 24, 2018

Indeed. Thank you.

@shyiko shyiko closed this as completed Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@shyiko @cable729 @hmhagberg @AleksandrSl