Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kscript comment-style directives are marked as errors with ktlint #273

Closed
0legg opened this issue Aug 28, 2018 · 2 comments
Closed

kscript comment-style directives are marked as errors with ktlint #273

0legg opened this issue Aug 28, 2018 · 2 comments

Comments

@0legg
Copy link
Contributor

0legg commented Aug 28, 2018

Similar to #212kscript uses comment-style directives and relying on no space after the double slash.

I'm not sure whether this issue belongs to ktlint of kscript though — my gut feeling is it's kscript who needs to adopt the change, but I'll cross-create tickets in both repos.

Ref kscripting/kscript#153

@0legg
Copy link
Contributor Author

0legg commented Aug 28, 2018

https://github.com/google/google-java-format/blob/4fa9d4967170109b1f8b238c12bb42ee9d26ba88/core/src/main/java/com/google/googlejavaformat/java/JavaCommentsHelper.java#L105-L108 For reference, GCF excludes few predefined annotation-alike comments from formatting, ktlint does the same for noinspection.

@shyiko
Copy link
Collaborator

shyiko commented Aug 28, 2018

To summarize:

right now user has an option to

ktlint could

kscript could

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants