Skip to content

Don't allow trigger_error() with a controller #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nicofuma opened this issue Oct 2, 2014 · 2 comments
Open

Don't allow trigger_error() with a controller #21

Nicofuma opened this issue Oct 2, 2014 · 2 comments

Comments

@Nicofuma
Copy link
Member

Nicofuma commented Oct 2, 2014

I think that you shoud throw an error for each trigger_error found in a controller and a warning for each trigger_error found anywhere else and if an extension call trigger_error in a "Symfony Event" (i.e. KernelEvents::*) it should be denied

@iMattPro
Copy link
Member

Not yet at least. The official Pages and Boardrules extensions are using (sort of) controllers for our ACP pages, and we have found that in those cases we must still use trigger_error. Using the a symfony response is not available to our controllers in the ACP.

i think maybe wait until we can truly not use trigger_error anymore in the ACP.

@Nicofuma
Copy link
Member Author

for the xCP yes, but not for the other controllers^^ (and I really want to try to move the xCP modules to DI and routing or3.2 :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants