Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile well-known protobuf types in remote cache / execution code #11411

Open
tdyas opened this issue Jan 5, 2021 · 0 comments
Open

compile well-known protobuf types in remote cache / execution code #11411

tdyas opened this issue Jan 5, 2021 · 0 comments

Comments

@tdyas
Copy link
Contributor

tdyas commented Jan 5, 2021

In the switch to Tonic, the "well-known" protobuf types (google.protobuf.*) are now provided by the prost-types crate. Binary fields in that generated code use Vec<u8> (which is the default in Prost). We should configure Prost to compile well-known protobuf types itself so that we can have binary fields use Bytes instead, which is more efficient.

Doing this is straight-forward but is blocked by a bug in Tonic documented in hyperium/tonic#521 and potentially resolved by hyperium/tonic#522.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants