Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the create subwallet type being the same type as admin wallet necessary? #3513

Open
jamshale opened this issue Feb 12, 2025 · 1 comment

Comments

@jamshale
Copy link
Contributor

In multitenant mode, when doing the anoncreds upgrade it was decided to force new wallets to be the same type as the admin wallet. The down side of this is it forces the controller to upgrade the admin wallet when it isn't needed. The admin wallet is indifferent to the subwallet wallet type. If the admin wallet is upgraded, now the controller can't create askar(indy) type wallets anymore.

I think we should remove this restriction when creating subwallets.

@ff137
Copy link
Contributor

ff137 commented Feb 13, 2025

As mentioned in the above link, I think that a restriction only makes sense if it impacts functionality.

Assume here the admin has an askar wallet. Restricting wallet creation to not allow askar-anoncreds, but allowing them to create askar and then separately upgrade to askar-anoncreds -- if that's the case, it feels like the initial restriction is unnecessary.

The only reasons I can think of for such a restriction is if something doesn't work properly, or if there's a change coming in a next release that'll impact it. If it just creates a hurdle of creating and then upgrading separately, that doesn't make sense imo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants